Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBLAS 0.3.5 memory leak on Cygwin #27509

Closed
embray opened this issue Mar 19, 2019 · 12 comments
Closed

OpenBLAS 0.3.5 memory leak on Cygwin #27509

embray opened this issue Mar 19, 2019 · 12 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 19, 2019

I discovered that part of the problem I've been having with OpenBLAS is that there is a pretty severe memory leak that gets worse any time an application with OpenBLAS loaded in it forks.

Upstream issue: OpenMathLib/OpenBLAS#2063

Upstream PR: OpenMathLib/OpenBLAS#2064

I already have a patch that I'll posting a PR for shortly, and would like to include in Sage. I'm just testing the patch now with Sage.

Component: porting: Cygwin

Author: Erik Bray

Branch/Commit: ee6e4a3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27509

@embray embray added this to the sage-8.7 milestone Mar 19, 2019
@embray

This comment has been minimized.

@embray
Copy link
Contributor Author

embray commented Mar 19, 2019

Author: Erik Bray

@embray

This comment has been minimized.

@embray
Copy link
Contributor Author

embray commented Mar 19, 2019

Branch: u/embray/ticket-27509

@embray
Copy link
Contributor Author

embray commented Mar 19, 2019

comment:3

If we can still have this one last patch applied for 8.7 that would be ideal, as this is a fairly bad issue. But it only especially becomes an issue when building and running the tests; probably less so in normal usage where running many subprocesses is slightly less common (except for some areas). I can possibly apply the patch and build openblas manually if absolute need be.


New commits:

ee6e4a3Trac #27509: Add patch from upstream pull request to fix memory leak on Cygwin

@embray
Copy link
Contributor Author

embray commented Mar 19, 2019

Commit: ee6e4a3

@tscrim
Copy link
Collaborator

tscrim commented Mar 20, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Mar 20, 2019

comment:4

Accepted upstream, so good for Sage.

@embray
Copy link
Contributor Author

embray commented Mar 25, 2019

comment:6

This is definitely a blocker.

@embray
Copy link
Contributor Author

embray commented Mar 25, 2019

comment:7

If need be I can still do something manually, but as far as I'm concerned it's still a severe problem.

@embray
Copy link
Contributor Author

embray commented Mar 25, 2019

comment:8

Moving all blocker/critical issues from 8.7 to 8.8.

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@vbraun
Copy link
Member

vbraun commented Mar 25, 2019

Changed branch from u/embray/ticket-27509 to ee6e4a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants