Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some pyflakes warning in matrix groups #27510

Closed
fchapoton opened this issue Mar 19, 2019 · 9 comments
Closed

fix some pyflakes warning in matrix groups #27510

fchapoton opened this issue Mar 19, 2019 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

some unused variables and imports

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: f6d0bfe

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27510
@fchapoton fchapoton added this to the sage-8.8 milestone Mar 19, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27510

@fchapoton
Copy link
Contributor Author

New commits:

27fd88efix some pyflakes warnings in matrix groups

@fchapoton
Copy link
Contributor Author

Commit: 27fd88e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 19, 2019

Changed commit from 27fd88e to f6d0bfe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 19, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

f6d0bfeadd back the singular ring assignement

@fchapoton
Copy link
Contributor Author

comment:3

ok, green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Mar 19, 2019

comment:4

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 19, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Mar 25, 2019

Changed branch from u/chapoton/27510 to f6d0bfe

@vbraun vbraun closed this as completed in 919636c Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton