Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scipy is a test dependency of networkx #27515

Closed
embray opened this issue Mar 20, 2019 · 8 comments
Closed

scipy is a test dependency of networkx #27515

embray opened this issue Mar 20, 2019 · 8 comments
Labels
c: packages: standard p: major / 3 t: bug
Milestone
sage-8.8

Comments

@embray
Copy link
Contributor

embray commented Mar 20, 2019

If building with SAGE_CHECK=yes and the networkx build completes and begins running its tests before scipy is built it will fail, since some of the tests use scipy.

Hence scipy should at least be an order-only prerequisite.

CC: @vbraun @Konrad127123 @dimpase

Component: packages: standard

Author: Erik Bray

Branch/Commit: 9549411

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27515
@embray embray added this to the sage-8.8 milestone Mar 20, 2019
@embray
Copy link
Contributor Author

embray commented Mar 20, 2019

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented Mar 20, 2019

Branch: u/embray/pkgs/networkx/test-dependencies-scipy

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

9549411Trac #27515: Add scipy as a dependency for the networkx test sutie

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2019

Commit: 9549411

@embray
Copy link
Contributor Author

embray commented Mar 20, 2019

New commits:

9549411Trac #27515: Add scipy as a dependency for the networkx test sutie

@dimpase
Copy link
Member

dimpase commented Mar 20, 2019

comment:4

LGTM

@dimpase
Copy link
Member

dimpase commented Mar 20, 2019

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Mar 25, 2019

Changed branch from u/embray/pkgs/networkx/test-dependencies-scipy to 9549411

@vbraun vbraun closed this as completed in 7aa42a9 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@embray @vbraun @dimpase