Improve Polyhedron.is_simple()

[kliem]

The method Polyhedron.is_simple is pretty slow for large polytopes at the moment. There is no need for that, as the information can be directly retrieved from the Vrepresentation.

Current timings:

sage: P = polytopes.hypercube(6)
sage: %time P.is_simple()
CPU times: user 360 ms, sys: 8 ms, total: 368 ms
Wall time: 364 ms
True
sage: P = polytopes.hypercube(7)
sage: %time P.is_simple()
CPU times: user 1.78 s, sys: 48 ms, total: 1.83 s
Wall time: 1.74 s
True
sage: P = polytopes.cross_polytope(7)
sage: %time P.is_simple()
CPU times: user 996 ms, sys: 0 ns, total: 996 ms
Wall time: 992 ms
False

Timings with this ticket:

sage: P = polytopes.hypercube(6)
sage: %time P.is_simple()
CPU times: user 4 ms, sys: 4 ms, total: 8 ms
Wall time: 3.53 ms
True
sage: P = polytopes.hypercube(7)
sage: %time P.is_simple()
CPU times: user 4 ms, sys: 4 ms, total: 8 ms
Wall time: 5.39 ms
True
sage: P = polytopes.cross_polytope(7)
sage: %time P.is_simple()
CPU times: user 8 ms, sys: 0 ns, total: 8 ms
Wall time: 5.63 ms
False
sage: P = polytopes.permutahedron(4)
sage: %time P.is_simple()
CPU times: user 0 ns, sys: 0 ns, total: 0 ns
Wall time: 1.03 ms
True

Component: geometry

Author: Jonathan Kliem

Branch/Commit: cd714a1

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/27533

[kliem]

Last 10 new commits:

3ec32e8	Merge branch 'public/upgrade_polymake_to_version_3_2r2' of trac.sagemath.org:sage into new_24905
f4dee94	Updated polymake to 3.2r4
d5b94d6	Fixed quotes and wiggled around
b2e133c	Fixed the typeof
d9af561	small fixes
40c6098	pep8
a5bf869	Fixed backend polymake
7a5de5a	Merge branch 'public/upgrade_polymake_to_version_3_2r4' of trac.sagemath.org:sage into polymake32r4
606f53f	Merge branch 'public/upgrade_polymake_to_version_3_2r4' of git://trac.sagemath.org/sage into develop
bd10eb3	Improved method ``is_simple``

[kliem]

Branch: public/27533

[kliem]

Commit: bd10eb3

[sagetrac-git]

Changed commit from bd10eb3 to f6aa8c6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

392ca56	Merge branch 'develop' of git://trac.sagemath.org/sage into develop
f6aa8c6	improved ``Polyhedron.is_simple()``

[sagetrac-git]

Changed commit from f6aa8c6 to ec41ee1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ec41ee1

improve is_simple

[kliem]

Changed branch from public/27533 to public/27533_new

[kliem]

Changed commit from ec41ee1 to cd714a1

[kliem]

comment:6

Had to fix my git develop branch

---

New commits:

cd714a1

improved is_simple

[kliem]

Changed branch from public/27533_new to public/27533

[kliem]

Author: Jonathan Kliem

[LaisRast]

comment:9

This is much faster than the previous way.
It looks fine to me.

[LaisRast]

Reviewer: Laith Rastanawi

[vbraun]

Changed branch from public/27533 to cd714a1