adding a small knot database

[fchapoton]

CC: @tscrim @miguelmarco

Component: algebraic topology

Keywords: knot

Author: Frédéric Chapoton

Branch/Commit: 10aa203

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27535

[fchapoton]

Commit: c7f42ff

[fchapoton]

Branch: u/chapoton/27535

[fchapoton]

comment:1

work in progress

---

New commits:

c7f42ff

trying to add one knot database

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fde1330

trac 27535 some more work on small knots table

[sagetrac-git]

Changed commit from c7f42ff to fde1330

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

56678bd

fix

[sagetrac-git]

Changed commit from fde1330 to 56678bd

[sagetrac-git]

Changed commit from 56678bd to 2b7adf3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2b7adf3

adding a small-knots database

[tscrim]

comment:5

+1

[sagetrac-git]

Changed commit from 2b7adf3 to 3f4908f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3f4908f

trac 27535 some details about knot table

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ac29a79

adding a small-knots database

[sagetrac-git]

Changed commit from 3f4908f to ac29a79

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a0897a3

adding a small-knots database

[sagetrac-git]

Changed commit from ac29a79 to a0897a3

[fchapoton]

comment:9

Please have a look.

[fchapoton]

Changed keywords from none to knot

[miguelmarco]

comment:12

This is a nice addition!

How did you const6ruct the table of knots? Used some scripts to parse the data from the knot atlas?

[fchapoton]

comment:13

Well, just taking the table and cleaning it by hand in emacs, using search-and-replace.

[fchapoton]

comment:14

green bot

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:15

I think this is a little misleading about the from_table input:

a pair of integers `(n, k)` where `n` is the crossing number

as it makes it seem like it should take a tuple. I think it would be better to have a more standard INPUT: block of

- ``n`` -- the crossing number
- ``k`` -- a positive integer

A little formatting thing, I think the first entry of the knot table should be on its own line instead of part of the small_knots_table = {. I would also indent all of them to make it clear they are enclosed in something.

Other than these two things, LGTM, and this will be a very nice addition to have.

[tscrim]

comment:16

Doing this for links might also be a good follow-up too based on this: http://katlas.org/wiki/The_Thistlethwaite_Link_Table

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

42d2d9b	Merge branch 'u/chapoton/27535' into 8.8.b0
10aa203	trac 27535 some details as suggested by reviewer

[sagetrac-git]

Changed commit from a0897a3 to 10aa203

[fchapoton]

comment:18

done, thx

[tscrim]

comment:19

Thanks. LGTM.

[vbraun]

Changed branch from u/chapoton/27535 to 10aa203