Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: cluster_algebra_quiver pickle depends on Python version #27545

Closed
jdemeyer opened this issue Mar 25, 2019 · 7 comments
Closed

py3: cluster_algebra_quiver pickle depends on Python version #27545

jdemeyer opened this issue Mar 25, 2019 · 7 comments

Comments

@jdemeyer
Copy link

The pickle cluster_algebra_quiver/mutation_classes_%s.dig6 currently depends on the Python version: pickles created with Python 3 cannot be opened with Python 2.

There are multiple solutions to this, such as ensuring that a pickle is always stored in a compatible version. But since these pickles are optional, a simpler solution is simply ignoring unpickling errors.

CC: @fchapoton @embray

Component: python3

Author: Jeroen Demeyer

Branch/Commit: a16ae1f

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27545

@jdemeyer jdemeyer added this to the sage-8.8 milestone Mar 25, 2019
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

a16ae1fIgnore all errors while unpickling cluster_algebra_quiver pickle

@jdemeyer
Copy link
Author

Commit: a16ae1f

@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:3

This has been a frequent source of annoyance for me as well. Personally I would prefer to have different versions of the file depending on the Python version. But at the same time most users won't be using Python 2 Sage and Python 3 Sage together on the same system, and even if we did do that, ignoring unpickle errors here would still be desirable. This is just a cache and regenerating the cache if needed is no big deal since it does not take so long.

@fchapoton
Copy link
Contributor

comment:4

ok, thx

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants