Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some comparisons to True, False and None #27572

Closed
fchapoton opened this issue Mar 30, 2019 · 10 comments
Closed

fix some comparisons to True, False and None #27572

fchapoton opened this issue Mar 30, 2019 · 10 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 0e029fb

Reviewer: Jeroen Demeyer, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27572
@fchapoton fchapoton added this to the sage-8.8 milestone Mar 30, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27572

@fchapoton
Copy link
Contributor Author

New commits:

7f776cdfix some comparisons to True, False and None

@fchapoton
Copy link
Contributor Author

Commit: 7f776cd

@jdemeyer
Copy link

comment:2

Instead of

ineg = bool(ik < 0)

even better would be

cdef bint ineg

that would automatically and efficiently convert to bool.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2019

Changed commit from 7f776cd to 0e029fb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

0e029fbtrac 27572 one detail

@fchapoton
Copy link
Contributor Author

comment:4

Thx, done (I hope that I have interpreted correctly the suggestion).

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2019

Reviewer: Jeroen Demeyer, Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2019

comment:6

LGTM.

Jeroen, I added you as a reviewer because of comment:2.

@vbraun
Copy link
Member

vbraun commented Apr 5, 2019

Changed branch from u/chapoton/27572 to 0e029fb

@vbraun vbraun closed this as completed in f745485 Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
4 participants
@vbraun @tscrim @jdemeyer @fchapoton