Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy import ssmod.py #27602

Closed
fchapoton opened this issue Apr 4, 2019 · 7 comments
Closed

lazy import ssmod.py #27602

fchapoton opened this issue Apr 4, 2019 · 7 comments
Labels
c: modular forms p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

plus some small changes inside that file

CC: @tscrim

Component: modular forms

Author: Frédéric Chapoton

Branch/Commit: 8b84985

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27602
@fchapoton fchapoton added this to the sage-8.8 milestone Apr 4, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27602

@fchapoton
Copy link
Contributor Author

New commits:

8b84985lazy import ssmod.py

@fchapoton
Copy link
Contributor Author

Commit: 8b84985

@fchapoton
Copy link
Contributor Author

comment:2

green bot, please review

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2019

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 7, 2019

Changed branch from u/chapoton/27602 to 8b84985

@vbraun vbraun closed this as completed in efd6ffe Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: modular forms p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton