New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: fix doctest with igraph #27628
Comments
Commit: |
New commits:
|
Branch: public/graphs/27628_igraph_graph |
comment:2
ok, looks good enough |
Reviewer: Frédéric Chapoton |
comment:3
Thank you Frederic for this super fast review ;) |
comment:4
There are a couple of failures of teh sort
|
comment:5
It's not due to this ticket (nothing to do with |
comment:6
Can we set this ticket back to positive review ? |
comment:8
I changed the way we check if igraph is installed to avoid a pyflakes error. |
This comment has been minimized.
This comment has been minimized.
comment:10
looks good to me. |
Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Dima Pasechnik |
comment:11
Well, let's do a follow up ticket since this is getting merged properly right now. Please refrain to introduce anymore call to
replacing the
|
comment:12
how about a ticket for getting rid of I wonder what pyflakes error one sees on a seemingly good try/except. |
comment:13
It is already on its way out. The only place it is not replaced by feature or something else at runtime is in It is currently impossible to totally remove it. doctesting with |
Changed branch from public/graphs/27628_igraph_graph to |
Changed commit from |
comment:15
There is an issue with igraph on the arando patchbot with 8.8.b4 and 8.8.b5:
|
comment:16
one can use a tag like
|
comment:17
it's what we do in #27811 ;) |
ordering issue.
Also change the way to check if igraph is installed to avoid a recurrent pyflakes error.
CC: @dimpase
Component: graph theory
Author: David Coudert
Branch:
1e773f5
Reviewer: Frédéric Chapoton, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/27628
The text was updated successfully, but these errors were encountered: