New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the code and the documentation for the coding section #27634
Comments
Branch: u/klee/27634 |
Author: Kwankyu Lee |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
sage/coding
section
sage/coding
section
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from u/jsrn/27634 to public/27634 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Johan Rosenkilde |
comment:34
Great, thanks for reacting so fast! Let's get this into Sage :-) Positive review. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:36
Ah... I could not resist rushing these final changes to this ticket. Sorry. I renamed "channel_constructions.py" to "channel.py" and "goppa.py" to "goppa_code.py". This seems to me more conforming to other file names. I worry that you may object to the former change. If so, let me know. |
comment:37
I'm OK with those changes, it's more conforming. Positive review. |
comment:38
See patchbot: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:40
Doctest failures in thematic tutorials were fixed by simple string replacements for changed module names. |
Changed branch from public/27634 to |
Lots of cleaning up of
sage/coding
folder:reorganize the section on coding in the documentation
PEP8 fixes
100% coverage for doctests
pyflakes fixes
rename
bch.py
tobch_code.py
andgrs.py
togrs_code.py
cleanups for
goppa.py
adding
random_received_vector
method to linear codesand other small fixes.
CC: @johanrosenkilde
Component: coding theory
Author: Kwankyu Lee
Branch/Commit:
8b01cc5
Reviewer: Johan Rosenkilde
Issue created by migration from https://trac.sagemath.org/ticket/27634
The text was updated successfully, but these errors were encountered: