New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make L.<x> syntax work for LazyLaurentSeriesRing #27694
Comments
comment:2
Does your proposal include importing |
comment:3
It is the case for |
comment:4
Replying to @slel:
I fear that it increases startup time. Perhaps using |
comment:5
Maybe that is the case for |
comment:6
Doesn't look like it's lazily imported, see the third hit in the search:
|
Author: Kwankyu Lee |
Branch: u/klee/27694 |
Commit: |
New commits:
|
comment:8
It's not lazily imported yet. Let's see how this affects the startup time first. |
comment:9
I would just lazily import it. There is no real harm in doing that. It just might take a moment to load when first using it in Sage. It is quite difficult to see how a single import changes startup time (unless it is really big); it is a "death by a 1000 needles" thing where it is the culmination of all the different modules. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
Ready for review? |
Reviewer: Travis Scrimshaw |
comment:14
LGTM. |
Changed branch from u/klee/27694 to |
Following #27347, one can use
It would be nice to have the syntactic sugar
work, just as it does for non-lazy:
The Sage preparser actually transforms the
L.<x>
input as follows:so methods
gens
and_first_ngens
are needed forLazyLaurentSeriesRing
.CC: @kwankyu @slel @tscrim
Component: algebra
Author: Kwankyu Lee
Branch/Commit:
3f28452
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/27694
The text was updated successfully, but these errors were encountered: