Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patchbot on Python 3 #27753

Closed
jdemeyer opened this issue Apr 30, 2019 · 10 comments
Closed

Fix patchbot on Python 3 #27753

jdemeyer opened this issue Apr 30, 2019 · 10 comments
Labels
c: scripts p: critical / 2 t: bug
Milestone
sage-8.8

Comments

@jdemeyer
Copy link

The sage --patchbot command no longer works, now that the patchbot requires Python 3.

Also add a new --pip3 command to make it easier to install the patchbot.

CC: @fchapoton

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: 7ffd38c

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/27753
@jdemeyer jdemeyer added this to the sage-8.8 milestone Apr 30, 2019
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

Branch: u/jdemeyer/fix_patchbot_on_python_3

@jdemeyer
Copy link
Author

Commit: 7ffd38c

@jdemeyer
Copy link
Author

New commits:

7ffd38cAdd --pip3 command and run patchbot with Python 3

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:4

ok, but you may well be the only "user" of that thing.

@jdemeyer
Copy link
Author

comment:5

I know you don't like it, but I find it very convenient.

@jhpalmieri
Copy link
Member

comment:6

I was using it until the patchbot changes broke my patchbot. (It is convenient because I didn't need my own separate Python installation with pyflakes, etc. — I could use Sage's.)

@vbraun
Copy link
Member

vbraun commented May 6, 2019

Changed branch from u/jdemeyer/fix_patchbot_on_python_3 to 7ffd38c

@vbraun vbraun closed this as completed in 37c2490 May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts p: critical / 2 t: bug
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
4 participants
@vbraun @jhpalmieri @jdemeyer @fchapoton