-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure threading in flint in sync with NTL #27764
Comments
Branch: u/dimpase/packages/flint-no-tls |
New commits:
|
Author: Dima Pasechnik |
Commit: |
comment:3
By default the latest |
comment:4
this is what Sage does, it disables threads in NTL. |
comment:5
an intelligent setup would sync this between dependencies automatically, but this seems to be not so easy. |
comment:6
Replying to @dimpase:
Well, we shouldn't anymore. I should have taken care of this during the ntl upgrade and things about C++11 standard. Unless there is a compelling reason to do so, I would recommend removing |
comment:7
On the other hand, flint's configuration system is un-impressive to me. And flint uses C++ for a grand total of compiling one file for the ntl interface. Which is optional. I have no idea if this is useful for anything. |
comment:9
flint’s interface to NTL is used in sagelib. So it cannot just be switched off. |
comment:10
Replying to @dimpase:
OK. That make something clearer to me. |
comment:11
Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically). |
comment:12
Needs rebasing. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:14
OK, done. |
comment:15
OK now that I see again what was done and that I remember the conversation let's move on a bit. There are two options
Is there any reason or platforms preventing us from enabling threads in NTL? We historically disabled threads in NTL because it relied on C++11 and we weren't on board with it for all packages and that was causing problems on downstream packages where c++11 wasn't on. This should be solved now. So is there another reason we cannot enable threads in NTL? |
comment:16
I suppose enabling threads in NTL and flint, and all its dependencies e.g. arb, needs testing on all platforms we claim to support. |
comment:17
That's a bot job. Literally. We should make a threading branch and see how the patch bots likes it. |
comment:18
Ticket retargeted after milestone closed |
comment:25
yes, this happens on macOS 10.15 too, it seems
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:28
from what I recall - I was able to build and test Sage 9.2.beta12 on Homebrew macOS 10.15.6 |
comment:30
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date. |
comment:31
Setting a new milestone for this ticket based on a cursory review. |
comment:32
Stalled in |
By default, TLS (aka Thread-Local Storage) is enabled in flint.
However, it contradicts to NTL configured without threads (
NTL_THREADS=off
), and in particular non-GNU linkers might refuse to link flint(actually happens on FreeBSD).
Also happens on macOS -- see for example https://groups.google.com/d/msg/sage-release/hobZzw74Rv0/VkAv7bG6DAAJ
See also:
CC: @embray @kiwifb @mkoeppe @dcoudert
Component: build
Author: Dima Pasechnik
Branch/Commit: u/dimpase/packages/flint-no-tls @
2945e30
Issue created by migration from https://trac.sagemath.org/ticket/27764
The text was updated successfully, but these errors were encountered: