Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SAGE_INSTALL_GCC variable #27817

Closed
dimpase opened this issue May 12, 2019 · 16 comments
Closed

remove SAGE_INSTALL_GCC variable #27817

dimpase opened this issue May 12, 2019 · 16 comments

Comments

@dimpase
Copy link
Member

dimpase commented May 12, 2019

I think with the latest —with-system-* options, it can and should be removed as superseded.

The branch here updated docs to make SAGE_INSTALL_GCC obsolete and
removed it everywhere, except one place. Alternative means to use
system compilers are explained.

The actual removal from the code will be done in a follow-up ticket.

CC: @kiwifb @embray @jdemeyer @mkoeppe @nthiery

Component: documentation

Author: Dima Pasechnik

Branch/Commit: a9c8ddd

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/27817

@dimpase dimpase added this to the sage-8.8 milestone May 12, 2019
@embray
Copy link
Contributor

embray commented May 13, 2019

comment:1

I think so too, though we might need better docs on how to run configure with specific flags when building from source.

This section of the installation docs mentions it, but it assumes you're building from a released source tarball, which already contains the configure script.

Whereas when building from a git checkout, which more and more people are likely to do these days, it's necessary to at least run make configure first (which, while slightly unusual, is I think justifiable).

@dimpase
Copy link
Member Author

dimpase commented May 13, 2019

comment:2

I agree that this should include the needed changes. These docs need cleaning badly, see
e.g.

Building all of Sage with Clang is currently not supported, see trac ticket #12426

which is manifestly not true, etc.

@dimpase
Copy link
Member Author

dimpase commented May 14, 2019

comment:3

OK, let me try to fix this.

@dimpase dimpase self-assigned this May 14, 2019
@dimpase
Copy link
Member Author

dimpase commented May 14, 2019

Commit: 4b5129c

@dimpase
Copy link
Member Author

dimpase commented May 14, 2019

@dimpase
Copy link
Member Author

dimpase commented May 14, 2019

comment:4

and this is only README.md fixes... (naturally, I could not stop until I made the whole text to reflect realty much better than it was)

@dimpase
Copy link
Member Author

dimpase commented May 22, 2019

comment:5

SAGE_INSTALL_GCC is used for two more or less orthogonal purposes: get input from the user, and for updating the toolchain (that's where it set to/tested for exists value).

Refactoring this is going to be fun...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2019

Changed commit from 4b5129c to a9c8ddd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 22, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

a9c8dddmarked SAGE_INSTALL_GCC obsolete, updated installation manual

@dimpase
Copy link
Member Author

dimpase commented May 22, 2019

Author: Dima Pasechnik

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member Author

dimpase commented May 22, 2019

comment:7

Don't know whether we should document how to force building of GCC.
(using --without-system-gcc, that is).

It is still far from ideal, but already a step forward from the hugely obsolete installation docs.

@dimpase
Copy link
Member Author

dimpase commented Jun 1, 2019

comment:9

these are really badly overdue documentation changes. let us get them in soon.

@mkoeppe
Copy link
Member

mkoeppe commented Jun 2, 2019

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Member

mkoeppe commented Jun 2, 2019

comment:10

Looks good to me. A major improvement.

@vbraun
Copy link
Member

vbraun commented Jun 5, 2019

Changed branch from public/documentation/remove_sage_install_gcc to a9c8ddd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants