Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some long() calls #27839

Closed
jdemeyer opened this issue May 16, 2019 · 9 comments
Closed

Remove some long() calls #27839

jdemeyer opened this issue May 16, 2019 · 9 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@jdemeyer
Copy link

In various places in Sage, there are explicit long(...) calls being done. Some of them are superfluous or can be replaced by int.

We don't try to fix all long() calls, just a few obviously avoidable ones.

CC: @jhpalmieri

Component: python3

Author: Jeroen Demeyer

Branch/Commit: acb54fa

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/27839
@jdemeyer jdemeyer added this to the sage-8.8 milestone May 16, 2019
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/remove_some_long___calls

@jdemeyer
Copy link
Author

Commit: acb54fa

@jdemeyer
Copy link
Author

New commits:

acb54faAvoid a few long() calls

@vinklein
Copy link
Mannequin

vinklein mannequin commented May 16, 2019

comment:6

Looks good to me.
Green bot => positive review.

@vinklein
Copy link
Mannequin

vinklein mannequin commented May 16, 2019

Reviewer: Vincent Klein

@vbraun
Copy link
Member

vbraun commented May 21, 2019

Changed branch from u/jdemeyer/remove_some_long___calls to acb54fa

@vbraun vbraun closed this as completed in ef24a11 May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
2 participants
@vbraun @jdemeyer