Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three more folders in python3-known-passing.txt #27867

Closed
fchapoton opened this issue May 24, 2019 · 12 comments
Closed

three more folders in python3-known-passing.txt #27867

fchapoton opened this issue May 24, 2019 · 12 comments

Comments

@fchapoton
Copy link
Contributor

to lock the progress towards python3

CC: @embray @jdemeyer @kiwifb @tscrim @jhpalmieri

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 697a1b9

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/27867

@fchapoton fchapoton added this to the sage-8.8 milestone May 24, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27867

@fchapoton
Copy link
Contributor Author

Commit: 242226f

@fchapoton
Copy link
Contributor Author

New commits:

242226fthree more python3-compatible folders

@jhpalmieri
Copy link
Member

comment:2

I get occasional failures in dynamics — this one about half the time:

sage -t src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py
**********************************************************************
File "src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py", line 1456, in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphisms_fixing_pair
Failed example:
    automorphisms_fixing_pair(f, L, False)
Expected:
    [(6*z + 6)/z, 6/(z + 1)]
Got:
    [6/(z + 1), (6*z + 6)/z]
**********************************************************************
1 item had failures:
   1 of   6 in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphisms_fixing_pair
    [114 tests, 1 failure, 1.04 s]

and this one once out of ten tries:

sage -t src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py
**********************************************************************
File "src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py", line 638, in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphism_group_QQ_CRT
Failed example:
    automorphism_group_QQ_CRT(f, 4, True)
Expected:
    [z, -z, 1/z, -1/z, (-z + 1)/(z + 1), (z + 1)/(z - 1), (z - 1)/(z + 1),
    (-z - 1)/(z - 1)]
Got:
    [z,
     -z,
     1/z,
     -1/z,
     (-z + 1)/(z + 1),
     (z + 1)/(z - 1),
     (-z - 1)/(z - 1),
     (z - 1)/(z + 1)]
**********************************************************************
File "src/sage/dynamics/arithmetic_dynamics/endPN_automorphism_group.py", line 647, in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphism_group_QQ_CRT
Failed example:
    automorphism_group_QQ_CRT(f, 4, False)
Expected:
    [
    [1 0]  [-1  0]  [0 1]  [ 0 -1]  [-1  1]  [ 1  1]  [ 1 -1]  [-1 -1]
    [0 1], [ 0  1], [1 0], [ 1  0], [ 1  1], [ 1 -1], [ 1  1], [ 1 -1]
    ]
Got:
    [
    [1 0]  [-1  0]  [0 1]  [ 0 -1]  [-1  1]  [ 1  1]  [-1 -1]  [ 1 -1]
    [0 1], [ 0  1], [1 0], [ 1  0], [ 1  1], [ 1 -1], [ 1 -1], [ 1  1]
    ]
**********************************************************************
1 item had failures:
   2 of   9 in sage.dynamics.arithmetic_dynamics.endPN_automorphism_group.automorphism_group_QQ_CRT

@jhpalmieri
Copy link
Member

comment:3

But if you remove dynamics from the list of good directories, positive review.

@fchapoton
Copy link
Contributor Author

comment:4

maybe we can rather sort these doctests ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2019

Changed commit from 242226f to 697a1b9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 24, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

697a1b9sorting some flaky doctests in dynamics

@fchapoton
Copy link
Contributor Author

comment:6

ok, I have added sorted and changed the doctests. Now the bots will not manage to check this ticket, because the python3-list is (stupidly) not in a "safe" location..

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:7

Okay with me.

@vbraun
Copy link
Member

vbraun commented May 27, 2019

Changed branch from u/chapoton/27867 to 697a1b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants