Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some doc details in projective_curve #27871

Closed
fchapoton opened this issue May 25, 2019 · 15 comments
Closed

some doc details in projective_curve #27871

fchapoton opened this issue May 25, 2019 · 15 comments
Labels
c: algebraic geometry p: trivial / 5 t: enhancement
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: algebraic geometry

Author: Frédéric Chapoton

Branch/Commit: 4edeb00

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/27871
@fchapoton fchapoton added this to the sage-8.8 milestone May 25, 2019
@fchapoton
Copy link
Contributor Author

Commit: 52c3f5c

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27871

@fchapoton
Copy link
Contributor Author

New commits:

52c3f5csome doc details in projective_curve.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Changed commit from 52c3f5c to 6fe9bc7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6fe9bc7trac 27871 fix

@fchapoton
Copy link
Contributor Author

comment:3

green bot, please review

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 26, 2019

comment:4

LGTM.

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented May 26, 2019

Reviewer: Thierry Monteil

@nbruin
Copy link
Contributor

nbruin commented May 26, 2019

comment:5

If you're going to touch up documentation, at least fix grammatical mistakes as well:
are worst that others -> are worse than others

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

d529710fix worse

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2019

Changed commit from 6fe9bc7 to d529710

@fchapoton
Copy link
Contributor Author

comment:7

Please note that it is not good practice to undo some positive review, unless there are very good reasons for that.

I allow myself to set back the ticket to positive.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2019

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

4edeb00some doc details in projective_curve.py

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2019

Changed commit from d529710 to 4edeb00

@vbraun
Copy link
Member

vbraun commented Jun 2, 2019

Changed branch from u/chapoton/27871 to 4edeb00

@vbraun vbraun closed this as completed in 777c3a9 Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic geometry p: trivial / 5 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @nbruin @fchapoton