Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-ticket: add integral curves over finite fields #27873

Closed
kwankyu opened this issue May 26, 2019 · 48 comments
Closed

Meta-ticket: add integral curves over finite fields #27873

kwankyu opened this issue May 26, 2019 · 48 comments

Comments

@kwankyu
Copy link
Collaborator

kwankyu commented May 26, 2019

We add integral curves over finite fields, tightly coupled with global function field machinery of Sage. The curves are space curves, including plane curves, in projective or affine spaces.

The main new functionalities are

  • finding all closed points (for each degree) of a curve,

  • finding all singular closed points of a curve.

Along the way, some old code in curves section of Sage is cleaned.


This ticket is now a meta-ticket to merge the code in multi steps:

step ticket comments
1 #27953 Add integral curves attached with function fields
2 #27954 Add closed points

The author was supported by NRF of Korea 2018, 2019, 2020

Component: algebraic geometry

Reviewer: Kwankyu Lee, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27873

@kwankyu kwankyu added this to the sage-8.8 milestone May 26, 2019
@kwankyu
Copy link
Collaborator Author

kwankyu commented May 26, 2019

Branch: u/klee/27873

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 26, 2019

Author: Kwankyu Lee

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

3c2286bfix
d51b9a6fix
0724b5cfix
1547849fix
a79c2cafix
56c3afffix
1adabe3Merge branch 'develop' into curves
9c999b0fix
5063823fix
4360779fix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Commit: 4360779

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

218d2f1Add integral curves over finite fields

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Changed commit from 4360779 to 218d2f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

265cacdpyflakes fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Changed commit from 218d2f1 to 265cacd

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 26, 2019

Dependencies: #27850

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

5448b0fAnother pyflakes fix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Changed commit from 265cacd to 5448b0f

@kwankyu

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Changed commit from 5448b0f to a488c75

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

a488c75Some cures for slow doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

13e1371Add integral curves over finite fields

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 26, 2019

Changed commit from a488c75 to 13e1371

@kwankyu

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

e746df9Improve doctest coverage

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 28, 2019

Changed commit from 13e1371 to e746df9

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:30

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@mkoeppe
Copy link
Member

mkoeppe commented Apr 14, 2020

comment:31

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@kwankyu

This comment has been minimized.

@nbruin
Copy link
Contributor

nbruin commented May 28, 2020

comment:33

Nitpick about terminology: the set of closed points of a curve over a finite field is infinite. The closed points of degree bounded by N form finite sets, for each N.
(ah, OK. the relevant code knows this. It's just the ticket description that's not reflecting it)

@kwankyu

This comment has been minimized.

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 29, 2020

comment:35

Replying to @nbruin:

Nitpick about terminology: the set of closed points of a curve over a finite field is infinite. The closed points of degree bounded by N form finite sets, for each N.
(ah, OK. the relevant code knows this. It's just the ticket description that's not reflecting it)

Right. Thanks for attention. I welcome more nitpicks.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Mar 15, 2021

comment:37

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 15, 2021
@kwankyu

This comment has been minimized.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Mar 25, 2021

comment:38

The mission is complete.

@kwankyu kwankyu removed this from the sage-9.4 milestone Mar 25, 2021
@tscrim
Copy link
Collaborator

tscrim commented Apr 16, 2021

Reviewer: Travis Scrimshaw

@slel
Copy link
Member

slel commented May 13, 2021

Changed author from Kwankyu Lee to none

@slel
Copy link
Member

slel commented May 13, 2021

Changed reviewer from Travis Scrimshaw to Kwankyu Lee, Travis Scrimshaw

@slel slel closed this as completed May 13, 2021
@slel slel changed the title Add integral curves over finite fields Meta-ticket: add integral curves over finite fields May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants