Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated dynamics code from schemes #27900

Closed
bhutz opened this issue May 30, 2019 · 13 comments
Closed

removed deprecated dynamics code from schemes #27900

bhutz opened this issue May 30, 2019 · 13 comments

Comments

@bhutz
Copy link

bhutz commented May 30, 2019

The dynamics code was relocated from schemes to dynamical systems in #23497 in Aug 2017. This ticket is to remove the deprecation warnings and functions that were left in place in schemes.

CC: @sagetrac-atowsley

Component: dynamics

Keywords: SI2019

Author: Ben Hutz

Branch/Commit: d88cdef

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27900

@bhutz bhutz added this to the sage-8.8 milestone May 30, 2019
@bhutz
Copy link
Author

bhutz commented May 31, 2019

Author: bhutz

@bhutz
Copy link
Author

bhutz commented May 31, 2019

Commit: e20ee18

@bhutz
Copy link
Author

bhutz commented May 31, 2019

New commits:

e20ee1827900: remove deprecated dynamics code from schemes

@bhutz
Copy link
Author

bhutz commented May 31, 2019

Branch: u/bhutz/27900_remove_deprecations

@bhutz bhutz self-assigned this May 31, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

d88cdef27900: fix doc tests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 31, 2019

Changed commit from e20ee18 to d88cdef

@bhutz
Copy link
Author

bhutz commented May 31, 2019

Changed author from bhutz to Ben Hutz

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2019

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2019

comment:6

Actually, Ben, could you quickly check that the failure in parent.pyx reported by the patchbot does not occur? I cannot test it right now. If it passes on your machine, you can set this back to a positive review.

@bhutz
Copy link
Author

bhutz commented Jun 3, 2019

comment:7

hmm...not sure here. I tested just that file and the patchbot failure line 1734 of that file fails both on my branch and on my clean beta branch. I seem to also get a failure on line 1737 of that file with the same maximum recursion depth error. These seem totally unrelated to the functionality I touched, but they are failing when I test that file.

'make ptestlong' did not have these failures for me.

@tscrim
Copy link
Collaborator

tscrim commented Jun 3, 2019

comment:8

I was pretty sure it was unrelated, but it is good to check. Thank you for checking. (Sorry I couldn't do it, my copies of Sage are all currently running some longer computations.)

@vbraun
Copy link
Member

vbraun commented Jun 6, 2019

Changed branch from u/bhutz/27900_remove_deprecations to d88cdef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants