Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in GAP package listing check due to different handling of user's .gap directory #27913

Closed
nthiery opened this issue Jun 1, 2019 · 3 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Jun 1, 2019

sage -t src/sage/tests/gap_packages.py
**********************************************************************
File "src/sage/tests/gap_packages.py", line 137, in sage.tests.gap_packages.all_installed_packages
Failed example:
    all_installed_packages() == all_installed_packages(gap=gap)
Expected:
    True
Got:
    False
**********************************************************************

This is because libgap includes my .gap directory (which contains a few packages) but not gap:

sage: gap('GAPInfo.RootPaths')
[ "/opt/sage-git/local/share/gap/" ]
sage: libgap.eval('GAPInfo.RootPaths')
[ "/home/nthiery/.gap/", "/opt/sage-git/local/share/gap/" ]

Potential actions:

  • Make gap and libgap behave consistently, presumably by having gap include the user's .gap directory
  • Consider that the sanity check is about system packages, and use the option "ignore_dot_gap" of all_gap_packages in the above test.

CC: @vbraun @tscrim @dimpase @embray

Component: interfaces

Issue created by migration from https://trac.sagemath.org/ticket/27913

@nthiery nthiery added this to the sage-8.8 milestone Jun 1, 2019
@kiwifb
Copy link
Member

kiwifb commented Jun 1, 2019

comment:1

Duplicate of #27878 really.

@nthiery
Copy link
Contributor Author

nthiery commented Jun 1, 2019

comment:2

Thanks François for the super-fast pointer!

@embray embray removed this from the sage-8.8 milestone Jun 3, 2019
@embray embray closed this as completed Jun 3, 2019
@embray
Copy link
Contributor

embray commented Jun 3, 2019

comment:4

Make gap and libgap behave consistently, presumably by having gap include the user's .gap directory

I believe the opposite should be the case: By default the GAP interfaces in Sage should ignore a user .gap because it could potentially interfere with the functionality of Sage itself.

In the pexpect interface there is an option for this but it doesn't currently work properly. We should fix it so that it does. On libgap it's trickier, but it's not currently possible to have multiple "embedded GAP interpreters" as it were. That would be a good chance to make in GAP, but would also require a lot of major work, so the safest option is for it to still ignore the user's .gap by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants