Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some pep details in sage-pkg #27927

Closed
fchapoton opened this issue Jun 4, 2019 · 6 comments
Closed

some pep details in sage-pkg #27927

fchapoton opened this issue Jun 4, 2019 · 6 comments
Labels
c: distribution p: minor / 4 t: enhancement
Milestone
sage-8.8

Comments

@fchapoton
Copy link
Contributor

also fixing one lgtm warning about unused variable

CC: @embray @jdemeyer @kiwifb @tscrim @vinklein

Component: distribution

Author: Frédéric Chapoton

Branch/Commit: ce30c92

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27927
@fchapoton fchapoton added this to the sage-8.8 milestone Jun 4, 2019
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/27927

@fchapoton
Copy link
Contributor Author

New commits:

ce30c92some details in sage-pkg

@fchapoton
Copy link
Contributor Author

Commit: ce30c92

@tscrim
Copy link
Collaborator

tscrim commented Jun 4, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 4, 2019

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 6, 2019

Changed branch from u/chapoton/27927 to ce30c92

@vbraun vbraun closed this as completed in 974dd47 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: distribution p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton