Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py3: Fix combinat.crystals.kac_modules.py for python3 #27945

Closed
vinklein mannequin opened this issue Jun 7, 2019 · 7 comments
Closed

Py3: Fix combinat.crystals.kac_modules.py for python3 #27945

vinklein mannequin opened this issue Jun 7, 2019 · 7 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.9

Comments

@vinklein
Copy link
Mannequin

vinklein mannequin commented Jun 7, 2019

Standard sorting issues.

CC: @tscrim

Component: python3

Author: Vincent Klein

Branch/Commit: a0876e8

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27945
@vinklein vinklein mannequin added this to the sage-8.8 milestone Jun 7, 2019
@vinklein vinklein mannequin added c: python3 labels Jun 7, 2019
@vinklein
Copy link
Mannequin Author

vinklein mannequin commented Jun 7, 2019

Branch: u/vklein/27945

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2019

Commit: a0876e8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a0876e8Trac #27945: Fix combinat.crystals.kac_modules...

@vinklein vinklein mannequin added the s: needs review label Jun 7, 2019
@tscrim
Copy link
Collaborator

tscrim commented Jun 7, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 7, 2019

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 27, 2019

Changed branch from u/vklein/27945 to a0876e8

@vbraun vbraun closed this as completed in 754e2d9 Jun 27, 2019
@embray
Copy link
Contributor

embray commented Jul 3, 2019

comment:7

Not in Sage 8.8. Let's please to try keep tickets' milestones related to the release in which we actually intend to include them, and in particular the release in which they were actually included, especially when closing tickets.

@embray embray modified the milestones: sage-8.8, sage-8.9 Jul 3, 2019
@fchapoton fchapoton mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@embray @vbraun @tscrim