Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dynatomic polynomial coerce base ring #27985

Closed
HTalbott mannequin opened this issue Jun 13, 2019 · 17 comments
Closed

Make dynatomic polynomial coerce base ring #27985

HTalbott mannequin opened this issue Jun 13, 2019 · 17 comments

Comments

@HTalbott
Copy link
Mannequin

HTalbott mannequin commented Jun 13, 2019

This ticket makes the following work:

sage: R.<c> = QQ[]
sage: Pc.<x, y> = ProjectiveSpace(R, 1)
sage: f = DynamicalSystem([xˆ2 + c*yˆ2, yˆ2], domain=Pc)
sage: k = FractionField(f.base_ring())
sage: new_fixed = 2
sage: m = matrix(k, 2, 2, [(new_fixed - 1)/new_fixed, 0, -1/new_fixed, 1])
sage: F = f.conjugate(m)
sage: F.dehomogenize(1).dynatomic_polynomial(2)

by making the dynatomic_polynomial function coerce to the correct base ring.

CC: @bhutz @sagetrac-msaaltink

Component: dynamics

Keywords: SI2019

Author: Henry Talbott

Branch/Commit: edafd35

Reviewer: Colby Kelln, Alex Shearer, Wayne Peng, Fiona Lu, Eric Zhu, Anna Chlopecki

Issue created by migration from https://trac.sagemath.org/ticket/27985

@HTalbott HTalbott mannequin added this to the sage-8.8 milestone Jun 13, 2019
@HTalbott HTalbott mannequin added p: minor / 4 labels Jun 13, 2019
@sagetrac-atowsley sagetrac-atowsley mannequin added the c: dynamics label Jun 13, 2019
@HTalbott
Copy link
Mannequin Author

HTalbott mannequin commented Jun 13, 2019

Branch: u/gh-HTalbott/27985

@HTalbott

This comment has been minimized.

@HTalbott
Copy link
Mannequin Author

HTalbott mannequin commented Jun 13, 2019

New commits:

fa912d4Fixed dynatomic polynomial function to coerce correct field

@HTalbott
Copy link
Mannequin Author

HTalbott mannequin commented Jun 13, 2019

Commit: fa912d4

@HTalbott HTalbott mannequin added the s: needs review label Jun 13, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2019

Changed commit from fa912d4 to a59231a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 13, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

a59231a27985: Dynatomic polynomial base field coercion

@slel

This comment has been minimized.

@slel slel changed the title Dynatomic polynomial fails to coerce base ring Make dynatomic polynomial coerce base ring Jun 13, 2019
@bhutz bhutz modified the milestones: sage-8.8, sage-8.9 Jun 14, 2019
@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Jun 18, 2019

Changed branch from u/gh-HTalbott/27985 to u/atowsley/27985

@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Jun 18, 2019

comment:8

Updated the branch since we were finally able to identify the root problem and fix it.


New commits:

5b2a99eUpdated inverse_of_unit in multi_polynomial_element

@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Jun 18, 2019

Changed commit from a59231a to 5b2a99e

@bhutz
Copy link

bhutz commented Jun 18, 2019

comment:10

You'll need documentation on that function before it can be marked positive, but we can test functionality.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2019

Changed commit from 5b2a99e to edafd35

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 18, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

edafd35Added new documentation.

@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Jun 18, 2019

comment:12

The documentation is there now. It just needs review.

@ckelln
Copy link
Mannequin

ckelln mannequin commented Jun 20, 2019

Reviewer: Colby Kelln, Alex Shearer, Wayne Peng, Fiona Lu

@Zopherus
Copy link
Mannequin

Zopherus mannequin commented Jun 20, 2019

Changed reviewer from Colby Kelln, Alex Shearer, Wayne Peng, Fiona Lu to Colby Kelln, Alex Shearer, Wayne Peng, Fiona Lu, Eric Zhu, Anna Chlopecki

@vbraun
Copy link
Member

vbraun commented Jul 7, 2019

Changed branch from u/atowsley/27985 to edafd35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants