MR16: Avoid creating files with name length > 255

[sagetrac-gitlab-bot]

Isuru Fernando (@isuruf) opened a merge request at https://gitlab.com/sagemath/sage/merge_requests/16:

---

CC: @videlec

Component: pickling

Keywords: days101

Author: Isuru Fernando

Branch/Commit: 6b27888

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/28014

[videlec]

comment:2

(porting a comment written in gitlab)

Why not hashing in all situations? If so there is no need to replace separator with underscores

    mangled = hashlib.sha256(os.path.realpath(SAGE_LIB).encode('utf-8')).hexdigest()

[isuruf]

comment:3

I think it was because I do .encode('utf-8') and was not sure if it works everywhere

[videlec]

comment:4

Your version is less intrusive but also less tested. If it works for you it is good enough for me :-)

[videlec]

Reviewer: Vincent Delecroix

[sagetrac-gitlab-bot]

Changed commit from 064a8c3 to 6b27888

[sagetrac-gitlab-bot]

comment:5

New commits added to merge request. I updated the commit SHA-1. New commits:

6b27888

Use hashing in all places

[isuruf]

comment:6

Some file systems (like the file system on cocalc) has a limit of 128. So, I've used your suggestion of hashing everywhere instead of checking for a limit

[videlec]

Changed keywords from none to days101

[vbraun]

Changed branch from u/galois/mrs/16/long_filename to 6b27888