Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document how to implement coercion for actions, using _act_on_ and _acted_upon_ #28017

Closed
dimpase opened this issue Jun 19, 2019 · 13 comments
Closed

document how to implement coercion for actions, using _act_on_ and _acted_upon_ #28017

dimpase opened this issue Jun 19, 2019 · 13 comments
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-8.9

Comments

@dimpase
Copy link
Member

dimpase commented Jun 19, 2019

This is a continuation of #27989

Depends on #27989

Component: documentation

Author: Kwankyu Lee

Branch/Commit: e75ecab

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28017
@dimpase dimpase added this to the sage-8.9 milestone Jun 19, 2019
@dimpase

This comment has been minimized.

Sign in to view
@dimpase
Copy link
Member Author

dimpase commented Jun 19, 2019

Dependencies: #27989

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 20, 2019

New commits:

c1c09b8trac 27989 purge _l_action and _r_action
f4a069dDocument _act_on and _acted_upon_

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 20, 2019

Author: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 20, 2019

Commit: f4a069d

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 20, 2019

Branch: u/klee/28017

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6704c49Fix an error in docstring formatting

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Changed commit from f4a069d to 6704c49

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

e75ecabAdd back The coercion model

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 20, 2019

Changed commit from 6704c49 to e75ecab

@dimpase
Copy link
Member Author

dimpase commented Jun 20, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Jun 20, 2019

comment:6

OK, good. Thanks for adding this.

@vbraun
Copy link
Member

vbraun commented Jun 28, 2019

Changed branch from u/klee/28017 to e75ecab

@vbraun vbraun closed this as completed in 7b65fbd Jun 28, 2019
@kwankyu kwankyu mentioned this issue Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@vbraun @dimpase @kwankyu