Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance change_ring method on morphisms to use canonical embedding when possible, give clearer error in other cases #28028

Closed
HTalbott mannequin opened this issue Jun 20, 2019 · 9 comments

Comments

@HTalbott
Copy link
Mannequin

HTalbott mannequin commented Jun 20, 2019

The following code does not work, and gives an unhelpful error message.

sage: R.<t>=QQ[]
sage: K.<v>=QuadraticField(2)
sage: K2.<w>=NumberField(t^4-2)
sage: P.<x,y>=ProjectiveSpace(QQ,1)
sage: phi=K.embeddings(K2)[0]
sage: f=DynamicalSystem_projective([x^2+3*y^2,y^2])
sage: f.change_ring(phi)

Since phi is an embedding of K into K2, and f has coefficients defined over QQ, phi cannot change the base ring of f. We add functionality to change_ring on morphisms so it uses the canonical embedding of the base ring of f into the domain of phi when such a canonical embedding exists. When such a canonical embedding does not exist, we add an error to change_ring noting the mismatch between the base ring of f and the domain of phi.

Component: number fields

Keywords: SI2019

Author: Henry Talbott

Branch/Commit: d85b712

Reviewer: Adam Towsley, Anna Chlopecki, Emily Rachfal, Juliano Levier-Gomes

Issue created by migration from https://trac.sagemath.org/ticket/28028

@HTalbott HTalbott mannequin added this to the sage-8.9 milestone Jun 20, 2019
@HTalbott HTalbott mannequin self-assigned this Jun 20, 2019
@HTalbott HTalbott mannequin added the t: enhancement label Jun 20, 2019
@HTalbott

This comment has been minimized.

@juliacai05
Copy link
Mannequin

juliacai05 mannequin commented Jun 21, 2019

Branch: u/gh-juliacai05/28028

@meggrip
Copy link
Mannequin

meggrip mannequin commented Jun 27, 2019

New commits:

0c4e09dTicket #28028: enhanced change_ring function to fix domain error

@meggrip
Copy link
Mannequin

meggrip mannequin commented Jun 27, 2019

Commit: 0c4e09d

@meggrip meggrip mannequin added the s: needs review label Jun 27, 2019
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2019

Changed commit from 0c4e09d to d85b712

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 27, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

d85b712ticket #28028, updated test formatting

@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Jun 27, 2019

Reviewer: Adam Towsley

@annanc2
Copy link
Mannequin

annanc2 mannequin commented Jun 27, 2019

Changed reviewer from Adam Towsley to Adam Towsley, Anna Chlopecki, Emily Rachfal, Juliano Levier-Gomes

@vbraun
Copy link
Member

vbraun commented Jul 10, 2019

Changed branch from u/gh-juliacai05/28028 to d85b712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant