Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spkg-configure.m4 for libatomic #28045

Closed
dimpase opened this issue Jun 21, 2019 · 10 comments
Closed

spkg-configure.m4 for libatomic #28045

dimpase opened this issue Jun 21, 2019 · 10 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@dimpase
Copy link
Member

dimpase commented Jun 21, 2019

this might need a tricky (?) check that the configuration is as needed for ecl.

otherwise, libatomic has no deps, and gc only depends on libatomic

CC: @embray @orlitzky

Component: build: configure

Author: Michael Orlitzky

Branch/Commit: e86ec71

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28045
@dimpase dimpase added this to the sage-8.9 milestone Jun 21, 2019
@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:1

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@orlitzky
Copy link
Contributor

Branch: u/mjo/ticket/28045

@orlitzky
Copy link
Contributor

comment:2

Should we do these separately? If gc winds up being tricky, we can do the dead-simple libatomic in the meantime.

@orlitzky
Copy link
Contributor

Commit: e86ec71

@orlitzky
Copy link
Contributor

comment:3

Let's do libatomic here, and gc in #28991. I'd like to get the easy ones out of the way and then we can spent as much time as it takes to do the tricky ones.

@orlitzky orlitzky changed the title spkg-configure.m4 for gc and libatomic spkg-configure.m4 for libatomic Jan 11, 2020
@isuruf
Copy link
Member

isuruf commented Jan 12, 2020

Reviewer: Isuru Fernando

@isuruf
Copy link
Member

isuruf commented Jan 12, 2020

comment:4

Works for me. gc finds it. checking which libatomic_ops to use... external

@fchapoton
Copy link
Contributor

comment:5

add missing Author full name, please

@orlitzky
Copy link
Contributor

Author: Michael Orlitzky

@vbraun
Copy link
Member

vbraun commented Jan 20, 2020

Changed branch from u/mjo/ticket/28045 to e86ec71

@vbraun vbraun closed this as completed in 878ff06 Jan 20, 2020
@embray embray mentioned this issue Jan 29, 2023
Open
@orlitzky orlitzky mentioned this issue Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
6 participants
@embray @vbraun @dimpase @orlitzky @isuruf @fchapoton