Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various lgtm fixes #28085

Closed
fchapoton opened this issue Jun 30, 2019 · 7 comments
Closed

various lgtm fixes #28085

fchapoton opened this issue Jun 30, 2019 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.9

Comments

@fchapoton
Copy link
Contributor

from

https://lgtm.com/projects/g/sagemath/sage/overview/

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: e92f66f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28085
@fchapoton fchapoton added this to the sage-8.9 milestone Jun 30, 2019
@fchapoton
Copy link
Contributor Author

Commit: e92f66f

@fchapoton
Copy link
Contributor Author

New commits:

e92f66fvarious lgtm fixes

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/28085

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@tscrim
Copy link
Collaborator

tscrim commented Jul 1, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 1, 2019

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Jul 5, 2019

Changed branch from u/chapoton/28085 to e92f66f

@vbraun vbraun closed this as completed in e7b18f0 Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton