MR27: Remove use of installed_packages for threejs

[sagetrac-gitlab-bot]

Isuru Fernando (@isuruf) opened a merge request at https://gitlab.com/sagemath/sage/merge_requests/27:

---

Depends on #28007

CC: @saraedum @paulmasson @kiwifb @antonio-rojas @timokau

Component: graphics

Keywords: threejs

Author: Isuru Fernando

Branch/Commit: c643b25

Reviewer: Paul Masson

Issue created by migration from https://trac.sagemath.org/ticket/28086

[sagetrac-gitlab-bot]

comment:2

New commits added to merge request. I updated the commit SHA-1. New commits:

1b17e52

add missing import os

[sagetrac-gitlab-bot]

Changed commit from 97fe175 to 1b17e52

[sagetrac-gitlab-bot]

Changed commit from 1b17e52 to ad4e8a9

[sagetrac-gitlab-bot]

comment:3

New commits added to merge request. I updated the commit SHA-1. New commits:

ad4e8a9

Add r to version

[paulmasson]

comment:4

While this will certainly work, what about a global variable THREEJS_VER evaluated just once?

[kiwifb]

comment:5

I am rather indifferent on how this is implemented. But even if create a variable THREEJS_VER in env.py it will be evaluated each time you call? Or are you thinking of hard-coding the version? I am not a big fan of hardcoding myself, is it really that detrimental?

[paulmasson]

comment:6

Was thinking env.py only ran once, but if it runs ever time it is called then there will be no difference.

[paulmasson]

Reviewer: Paul Masson

[paulmasson]

Dependencies: #28007

[paulmasson]

comment:7

Works for me

[paulmasson]

Changed keywords from none to threejs

[fchapoton]

comment:8

Patchbot reports several doctest failures, guys..

And patchbot plugins are not green either.

[kiwifb]

comment:9

That's because the dependency at #28007 is merged and closed but not in any release or beta yet. I am surprised it merges on the patchbots.

[fchapoton]

comment:11

ok then, but still the plugins "pyflakes" and "pycodestyle" are not green.

[sagetrac-gitlab-bot]

comment:12

New commits added to merge request. I updated the commit SHA-1. New commits:

c643b25

Fix formatting error

[sagetrac-gitlab-bot]

Changed commit from ad4e8a9 to c643b25

[isuruf]

comment:13

pyflakes error is for a line I didn't change. I've fixed pycodestyle error.

[paulmasson]

comment:14

Any good reason not to set this back to positive review?

[vbraun]

Changed branch from u/galois/mrs/27/threejs to c643b25