Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _number_field_from_algebraics() return a dynamical system #28161

Closed
oliviaschwager mannequin opened this issue Jul 10, 2019 · 11 comments
Closed

Make _number_field_from_algebraics() return a dynamical system #28161

oliviaschwager mannequin opened this issue Jul 10, 2019 · 11 comments

Comments

@oliviaschwager
Copy link
Mannequin

oliviaschwager mannequin commented Jul 10, 2019

The current function for dynamical system inherits from schemeMorphism_polynomial and doesn't return a dynamical system object.

P.<x,y>=ProjectiveSpace(QQbar,1)
f=DynamicalSystem_projective([x^2 + QQbar(sqrt(2))*y^2, y^2])
f._number_field_from_algebraics()

Component: dynamics

Keywords: SI2019

Author: Jasmine Camero, Olivia Schwager

Branch/Commit: f9db110

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/28161

@oliviaschwager oliviaschwager mannequin added this to the sage-8.9 milestone Jul 10, 2019
@jasminecamero
Copy link
Mannequin

jasminecamero mannequin commented Jul 11, 2019

Branch: u/gh-jasminecamero/master

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6c9c01f28161: from_algebraics return ds

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2019

Commit: 6c9c01f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2019

Changed commit from 6c9c01f to b33de77

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

b33de7728161 returns ds

@bhutz
Copy link

bhutz commented Jul 14, 2019

Changed branch from u/gh-jasminecamero/master to u/bhutz/master

@bhutz
Copy link

bhutz commented Jul 14, 2019

Changed branch from u/bhutz/master to u/bhutz/28161

@bhutz
Copy link

bhutz commented Jul 14, 2019

Reviewer: Ben Hutz

@bhutz
Copy link

bhutz commented Jul 14, 2019

Changed commit from b33de77 to f9db110

@bhutz
Copy link

bhutz commented Jul 14, 2019

comment:6

This looks fine to me. I updated the docs though. So if that update is fine with you, go ahead and mark this positive.


New commits:

5a75f00Merge branch 8.9.beta2 into t/28161/master
f9db11028161: update docs

@vbraun
Copy link
Member

vbraun commented Jul 23, 2019

Changed branch from u/bhutz/28161 to f9db110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants