Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep8 cleanup of toy_buchberger #28203

Closed
mwageringel opened this issue Jul 15, 2019 · 13 comments
Closed

pep8 cleanup of toy_buchberger #28203

mwageringel opened this issue Jul 15, 2019 · 13 comments
Labels
c: commutative algebra p: minor / 4 t: enhancement
Milestone
sage-8.9

Comments

@mwageringel
Copy link

This is a follow-up ticket of #27908 and fixes most of the PEP8 warnings, except for lambdas and long lines in example blocks.

Component: commutative algebra

Author: Markus Wageringel

Branch/Commit: a085d23

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/28203
@mwageringel mwageringel added this to the sage-8.9 milestone Jul 15, 2019
@mwageringel
Copy link
Author

Author: Markus Wageringel

@mwageringel
Copy link
Author

Commit: 4095e7f

@mwageringel
Copy link
Author

Branch: u/gh-mwageringel/28203

@mwageringel
Copy link
Author

New commits:

4095e7f28203: some PEP cleaning of toy_buchberger

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2019

Changed branch from u/gh-mwageringel/28203 to public/28203

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2019

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2019

comment:2

It looks good to me. I added even more tidy-ups. If you like my additions, then you can set to positive review.

New commits:

08ad0e2A few more tidy-ups

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2019

Changed commit from 4095e7f to 08ad0e2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2019

Changed commit from 08ad0e2 to a085d23

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

a085d2328203: fix hyperlink and pyflakes warnings

@mwageringel
Copy link
Author

comment:4

Thank you. Your changes look good to me. I fixed the hyperlink to groebner_basis() as well as the issues reported by pyflakes. If you agree, you can set to positive.

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 17, 2019

comment:5

Looks good.

@vbraun
Copy link
Member

vbraun commented Jul 23, 2019

Changed branch from public/28203 to a085d23

@vbraun vbraun closed this as completed in 104da14 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: commutative algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@vbraun @kwankyu @mwageringel