Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Theory Documentation Update #28209

Closed
emes4 opened this issue Jul 17, 2019 · 23 comments
Closed

Coding Theory Documentation Update #28209

emes4 opened this issue Jul 17, 2019 · 23 comments

Comments

@emes4
Copy link

emes4 commented Jul 17, 2019

With the changes to the coding theory framework (#28073, #28350) and new additions (#21226), some of the bigger documentation files need changing. These are the thematic tutorials on coding theory and creating a class in coding theory, as well as the linear code construction documentation. It might also be a good idea to add new tutorials on how to create a generic code/rank-metric code.

CC: @dimpase @johanrosenkilde @emes4 @xcaruso @mbombar

Component: coding theory

Keywords: gsoc19

Author: Marketa Slukova

Branch/Commit: d44d677

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28209

@emes4 emes4 added this to the sage-8.9 milestone Jul 17, 2019
@dimpase
Copy link
Member

dimpase commented Jul 17, 2019

comment:2

reporters and commenters are cc'd automatically.

@johanrosenkilde
Copy link
Contributor

comment:3

This ticket should depend on #28073 and #21226, not the other way around. I.e. we first need to green-light #28073 and #21226, and then we can make some updates to the tutorials.

Regarding the documentation in the linear code class, we should update that already in #28073 or #21226 only if it is very misleading. Consider the state of SageMath if those two tickets were merged but this one wasn't: is the documentation in linear code then somewhat reasonable or completely wrong?

@emes4
Copy link
Author

emes4 commented Jul 29, 2019

Dependencies: #28073, #21226

@emes4
Copy link
Author

emes4 commented Jul 29, 2019

comment:5

The documentation in linear_code should be completely reasonable, I changed it along the way as I was working on AbstractCode. The only issue are the bigger documentation files - maybe it would be best to temporarily take them out of Sage before they are edited so they don't confuse anyone?

@dimpase
Copy link
Member

dimpase commented Jul 30, 2019

comment:6

Replying to @emes4:

The documentation in linear_code should be completely reasonable, I changed it along the way as I was working on AbstractCode. The only issue are the bigger documentation files - maybe it would be best to temporarily take them out of Sage before they are edited so they don't confuse anyone?

I think it's OK to have such inconsistencies as long as they don't make it into a stable release, which probably won't happen before Sept.

@emes4

This comment has been minimized.

@emes4
Copy link
Author

emes4 commented Aug 24, 2019

Changed dependencies from #28073, #21226 to #28073, #21226, #28350

@emes4
Copy link
Author

emes4 commented Aug 25, 2019

Branch: u/gh-emes4/coding/documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2019

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f7d9438Merge in 28350, Linear Code No Metric
d4d3e89No Metric changes. Removed Relative Finite Field Extension, added vector_space method and basis option. Doctests and documentation. Deleted rank metric specific encoders.
1e32a0cSuper method of LinearRankMetricCode includes basis.
3917048Merge branch 'develop' of git://trac.sagemath.org/sage into rank_metric
01d9a3dMerge branch 'develop' of git://trac.sagemath.org/sage into t/28350/abstract_linear_code_no_metric_class
226ffbfAdded no metric to coding documentation index. Moved zero method from AbstractLinearCode. Changed base_field check.
bd31704Merge branch 'u/gh-emes4/coding/no_metric' of git://trac.sagemath.org/sage into rank_metric
0a115d0Removed zero method. Added field extension method.
f6ab136Documentation changes to coding module.
a6d14cbThematic tutorials updated.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2019

Commit: a6d14cb

@emes4
Copy link
Author

emes4 commented Aug 25, 2019

comment:10

I made necessary changes to the documentation in the coding module as well as some of the thematic tutorials.

For the thematic tutorials, I mostly tried to keep them as they were, correct things that were not relevant and add some new examples. I tried a few different things, but keeping in mind the audience for these tutorials, I decided to still keep the focus on linear codes over the Hamming metric.

In Coding Theory, I just added a new section explaining that there are other classes supporting codes which are not necessarily linear and/or over the Hamming metric, and added an example of a rank metric code.

In Structures in Coding Theory, I kept the main example of the repetition code throughout the tutorial. I added a section on the structure of the abstract classes in the beginning and also added a small example of a non-linear code family.

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:12

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@mkoeppe
Copy link
Member

mkoeppe commented Apr 14, 2020

comment:13

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Aug 15, 2020

Author: Marketa Slukova

@dimpase
Copy link
Member

dimpase commented Aug 24, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Aug 24, 2020

Changed branch from u/gh-emes4/coding/documentation to public/coding/docfix2019

@dimpase
Copy link
Member

dimpase commented Aug 24, 2020

Changed commit from a6d14cb to 9641e92

@dimpase
Copy link
Member

dimpase commented Aug 24, 2020

Changed dependencies from #28073, #21226, #28350 to none

@dimpase
Copy link
Member

dimpase commented Aug 24, 2020

New commits:

bee08caDocumentation changes to coding module.
2342a3aThematic tutorials updated.
9641e92follow pyflakes advise

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

d44d677fix a doctest in the tutorial

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2020

Changed commit from 9641e92 to d44d677

@dimpase
Copy link
Member

dimpase commented Aug 24, 2020

comment:19

lgtm, off to the bots

@vbraun
Copy link
Member

vbraun commented Aug 30, 2020

Changed branch from public/coding/docfix2019 to d44d677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants