New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: fix doctests in doctest/test #28232
Labels
Milestone
Comments
New commits:
|
Commit: |
Author: Markus Wageringel |
Branch: u/gh-mwageringel/28232 |
comment:2
Nice work. Looks good to me. |
Reviewer: John Palmieri |
Changed branch from u/gh-mwageringel/28232 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This ticket fixes the last Python 3 doctest failure in doctest/test.py.
The problem is that the doctest dispatcher relies on internals of the multiprocessing library, which slightly changed in Python 3; see the relevant file. Because of that, until now with Python 3, the master doctest process waits for its children to exit before exiting itself, even though it is not supposed to.
I also adjusted the affected doctest so that it checks for what was initially intended. This got lost when the minimum
die_timeout
of subprocesses got increased from 20 to 60 seconds, but this also means the doctest now lasts 40 seconds longer than before.Component: python3
Author: Markus Wageringel
Branch/Commit:
4be8c5d
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/28232
The text was updated successfully, but these errors were encountered: