Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rational methods of the backend normaliz to the _QQ class #28240

Closed
jplab opened this issue Jul 23, 2019 · 8 comments
Closed

Move rational methods of the backend normaliz to the _QQ class #28240

jplab opened this issue Jul 23, 2019 · 8 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-8.9

Comments

@jplab
Copy link

jplab commented Jul 23, 2019

Now that the normaliz backend allows algebraic values, it makes sense to move the rational polyhedral methods to the rational base class.

CC: @jplab @mkoeppe @videlec @fchapoton

Component: geometry

Keywords: polytopes, normaliz, days100

Author: Jean-Philippe Labbé

Branch/Commit: 436dbc3

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28240
@jplab jplab added this to the sage-8.9 milestone Jul 23, 2019
@jplab
Copy link
Author

jplab commented Jul 23, 2019

comment:1

The Ehrhart polynomial business is going to be taken care of in #18957.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

7b4318dpyflakes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Changed commit from 436dbc3 to 7b4318d

@jplab
Copy link
Author

jplab commented Jul 24, 2019

comment:4

OOps!!! My bad! Wrong branch!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Changed commit from 7b4318d to 436dbc3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@vbraun
Copy link
Member

vbraun commented Jul 29, 2019

Changed branch from u/jipilab/move_norm_features to 436dbc3

@vbraun vbraun closed this as completed in 3237170 Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.9
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @jplab