Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in ClusterSeed involving coefficients #28264

Open
sagetrac-gmoose05 mannequin opened this issue Jul 25, 2019 · 12 comments
Open

Fixing bug in ClusterSeed involving coefficients #28264

sagetrac-gmoose05 mannequin opened this issue Jul 25, 2019 · 12 comments

Comments

@sagetrac-gmoose05
Copy link
Mannequin

sagetrac-gmoose05 mannequin commented Jul 25, 2019

EARLIER: Bug found in S.interact() or Q.interact() for ClusterSeed or ClusterQuiver. (This appears to be an issue with interact() in CoCalc as opposed to in our code.)

NEW Description: In process of debugging handling of coefficients and frozen variables in cluster seed.

CC: @egunawan

Component: combinatorics

Keywords: cluster

Branch/Commit: u/gmoose05/fix_interact_for_clusterquiver_and_clusterseed @ 5274b5f

Issue created by migration from https://trac.sagemath.org/ticket/28264

@sagetrac-gmoose05 sagetrac-gmoose05 mannequin added this to the sage-8.9 milestone Jul 25, 2019
@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jul 25, 2019

comment:1

Current code (in a Jupyter notebbok) mutates at last clicked value as opposed to the current clicked value, and always mutates at 0 first.

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jul 25, 2019

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jul 25, 2019

Changed branch from u/gmoose05/fix_interact_for_clusterquiver_and_clusterseed to none

@sagetrac-gmoose05

This comment has been minimized.

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jul 25, 2019

comment:3

First step: ensure that any cluster seed comes with a "user_label", even if it needs to be automatically populated to be [0,1,2,...n-1].

Later: this attribute name will be renamed to make it clear it is not only user_label.

@sagetrac-gmoose05 sagetrac-gmoose05 mannequin changed the title Fix Interact for ClusterQuiver and ClusterSeed Fixing bug in ClusterSeed involving coefficients Jul 25, 2019
@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jul 25, 2019

@fchapoton
Copy link
Contributor

Commit: 5274b5f

@fchapoton
Copy link
Contributor

comment:5

Please add a doctest for what it fixes.


New commits:

5f3d830Trying To Debug principal_extension
5274b5fChanged code so that user_labels are always assigned, even if it is [0,1,2,...,n-1]

@fchapoton
Copy link
Contributor

Changed keywords from none to cluster

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:7

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@mkoeppe
Copy link
Member

mkoeppe commented May 1, 2020

comment:8

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 May 1, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Member

mkoeppe commented May 10, 2021

comment:10

Moving to 9.4, as 9.3 has been released.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 May 10, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe removed this from the sage-9.6 milestone May 3, 2022
@mkoeppe mkoeppe added this to the sage-9.7 milestone May 3, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants