Readabiltiy fixes for sage-coding-theory goppa_code.py

[927589452]

I will use this ticket to collect a few improvements I wanted to suggest for the coding theory projects goppa implementation

CC: @emes4

Component: coding theory

Branch/Commit: u/gh-927589452/coding_theory_suggestions @ c9fb9f0

Issue created by migration from https://trac.sagemath.org/ticket/28381

[927589452]

Branch: u/gh-927589452/coding_theory_suggestions

[dimpase]

comment:3

it seems that you don't have the correct branch pushed.

[sagetrac-git]

Commit: 9953e4e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9953e4e

Merge all rows in one loop

[927589452]

comment:5

Replying to @dimpase:

it seems that you don't have the correct branch pushed.

Not exactly
I hadn't pushed it yet to the trac server

[927589452]

comment:6

Replying to @sagetrac-git:

Branch pushed to git repo; I updated commit sha1. New commits:

9953e4e

Merge all rows in one loop

This is just a cleaner / better readable version of the parity check generation

[dimpase]

comment:7

This needs to be done over current beta (beta 7), not beta 3. As you see, your branch does not merge cleanly over the current beta (it is shown in red).

[927589452]

comment:8

Replying to @dimpase:

This needs to be done over current beta (beta 7), not beta 3. As you see, your branch does not merge cleanly over the current beta (it is shown in red).

will do

[sagetrac-git]

Changed commit from 9953e4e to c9fb9f0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c9fb9f0

Merge all rows in one loop

[927589452]

comment:10

Replying to @dimpase:

This needs to be done over current beta (beta 7), not beta 3. As you see, your branch does not merge cleanly over the current beta (it is shown in red).

fixed it

(thanks to https://stackoverflow.com/questions/3491270/git-merge-apply-changes-to-code-that-moved-to-a-different-file )

[embray]

comment:12

Please update the ticket title to better summarize what is being improved

[927589452]

comment:13

updated title

[embray]

comment:14

Ticket retargeted after milestone closed

[mkoeppe]

comment:15

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

[mkoeppe]

comment:17

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.