Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subjoinsemilattice #28416

Closed
jm58660 mannequin opened this issue Aug 28, 2019 · 14 comments
Closed

Add subjoinsemilattice #28416

jm58660 mannequin opened this issue Aug 28, 2019 · 14 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Aug 28, 2019

When #27818 is closed add the dual of it.

Component: combinatorics

Author: Jori Mäntysalo

Branch/Commit: 18cd74e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28416

@jm58660 jm58660 mannequin added this to the sage-8.9 milestone Aug 28, 2019
@jm58660 jm58660 mannequin added c: combinatorics labels Aug 28, 2019
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 11, 2019

Branch: u/jmantysalo/add_subjoinsemilattice

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 11, 2019

comment:2

Trivial dual function.


New commits:

8a955baAdd dual for sub-meetsemilattice.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 11, 2019

Commit: 8a955ba

@jm58660 jm58660 mannequin added the s: needs review label Sep 11, 2019
@fchapoton
Copy link
Contributor

comment:3

typo in "gens_remaning" comment

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 14, 2019

comment:4

Replying to @fchapoton:

typo in "gens_remaning" comment

Sorry, I didn't get this. Where?

@fchapoton
Copy link
Contributor

comment:5

in the comments (also in the previous similar ticket) remaning >>> remaining

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

18cd74eA typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 14, 2019

Changed commit from 8a955ba to 18cd74e

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 14, 2019

comment:7

Replying to @fchapoton:

in the comments (also in the previous similar ticket) remaning >>> remaining

Ah, I just skipped it as "code"... Thanks.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:8

ok.

I would have called that "meet_closure" and "join_closure".

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 16, 2019

comment:9

Replying to @fchapoton:

I would have called that "meet_closure" and "join_closure".

True. Would have been better.

@fchapoton
Copy link
Contributor

comment:10

moving milestone to 9.0 (after release of 8.9)

@fchapoton fchapoton modified the milestones: sage-8.9, sage-9.0 Sep 30, 2019
@vbraun
Copy link
Member

vbraun commented Oct 6, 2019

Changed branch from u/jmantysalo/add_subjoinsemilattice to 18cd74e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants