Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyhedralFan of Groebner fan is created twice #28522

Closed
jplab opened this issue Sep 20, 2019 · 3 comments
Closed

PolyhedralFan of Groebner fan is created twice #28522

jplab opened this issue Sep 20, 2019 · 3 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.0

Comments

@jplab
Copy link

jplab commented Sep 20, 2019

When creating the PolyhedralFan of a Gröbner fan, it is actually created twice. We fix this:

            f = self.gfan(cmd='topolyhedralfan', I=self._gfan_reduced_groebner_bases())
            self.__polyhedralfan = PolyhedralFan(f)
-           return PolyhedralFan(f)
+           return self.__polyhedralfan

CC: @fchapoton

Component: geometry

Keywords: groebner

Author: Jean-Philippe Labbé

Branch/Commit: bb66272

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/28522
@jplab jplab added this to the sage-9.0 milestone Sep 20, 2019
@fchapoton
Copy link
Contributor

comment:2

Oui. Pas terrible.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Oct 5, 2019

Changed branch from u/jipilab/groebner to bb66272

@vbraun vbraun closed this as completed in 77ec966 Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @jplab