Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cleanup in mod 2 tests #28545

Closed
fchapoton opened this issue Sep 30, 2019 · 20 comments
Closed

some cleanup in mod 2 tests #28545

fchapoton opened this issue Sep 30, 2019 · 20 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.0

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: f0d5518

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28545
@fchapoton fchapoton added this to the sage-9.0 milestone Sep 30, 2019
@fchapoton
Copy link
Contributor Author

New commits:

6fe811da bunch of trivial mod2 changes

@fchapoton
Copy link
Contributor Author

Commit: 6fe811d

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/28545

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2019

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2019

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 5, 2019

comment:3

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 5, 2019

Changed commit from 6fe811d to 44c76d4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 5, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

44c76d4Merge branch 'u/chapoton/28545' of 9.0.b0

@fchapoton
Copy link
Contributor Author

comment:5

merged with 9.0.b0

@vbraun
Copy link
Member

vbraun commented Oct 6, 2019

comment:7

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 21, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

ab16ab3Merge branch 'u/chapoton/28545' in 9.0.b2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 21, 2019

Changed commit from 44c76d4 to ab16ab3

@fchapoton
Copy link
Contributor Author

comment:9

fixed the merge conflict, setting back to positive

@vbraun
Copy link
Member

vbraun commented Oct 22, 2019

comment:10
sage -t --long --warn-long 61.0 src/sage/symbolic/assumptions.py
**********************************************************************
File "src/sage/symbolic/assumptions.py", line 309, in sage.symbolic.assumptions.GenericDeclaration.contradicts
Failed example:
    GenericDeclaration(x, 'even').contradicts(x==3)
Expected:
    True
Got:
    1
**********************************************************************

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

f0d5518trac 28545 fixing doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2019

Changed commit from ab16ab3 to f0d5518

@fchapoton
Copy link
Contributor Author

comment:12

fixed

New commits:

f0d5518trac 28545 fixing doctests

New commits:

f0d5518trac 28545 fixing doctests

@fchapoton
Copy link
Contributor Author

comment:13

green bot, please review the fix.

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2019

comment:14

Thanks. LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 27, 2019

Changed branch from u/chapoton/28545 to f0d5518

@vbraun vbraun closed this as completed in 9088553 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton