Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some typos and https #28601

Closed
fchapoton opened this issue Oct 14, 2019 · 11 comments
Closed

some typos and https #28601

fchapoton opened this issue Oct 14, 2019 · 11 comments
Labels
c: documentation p: trivial / 5 t: enhancement
Milestone
sage-9.0

Comments

@fchapoton
Copy link
Contributor

CC: @tscrim @jm58660

Component: documentation

Author: Frédéric Chapoton

Branch/Commit: 25e0186

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/28601
@fchapoton fchapoton added this to the sage-9.0 milestone Oct 14, 2019
@fchapoton
Copy link
Contributor Author

Commit: 8a6fb0a

@fchapoton
Copy link
Contributor Author

New commits:

57171a1some typos
078f931more typos
8a6fb0asome https for trac links

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/28601

@fchapoton
Copy link
Contributor Author

comment:2

bot is morally green, please review

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Oct 14, 2019

Reviewer: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Oct 14, 2019

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 15, 2019

comment:4

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 21, 2019

Changed commit from 8a6fb0a to 25e0186

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 21, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

25e0186Merge branch 'u/chapoton/28601' in 9.0.b2

@fchapoton
Copy link
Contributor Author

comment:6

fixed the merge conflict, setting back to positive

@vbraun
Copy link
Member

vbraun commented Oct 23, 2019

Changed branch from u/chapoton/28601 to 25e0186

@vbraun vbraun closed this as completed in 3a05817 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: trivial / 5 t: enhancement
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
2 participants
@vbraun @fchapoton