CombinatorialPolyhedron: edge_graph -> vertex_graph

[kliem]

In order to make CombinatorialPolyhedron more consistent with Polyhedron, we replace edge_graph by vertex_graph.

In case of of unbounded polyhedra this might make a difference, as unbounded 1-faces are considered for edge_graph but not for vertex_graph.

For now we keep edge_graph and add a deprecation warning.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: ecb7986

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/28603

[kliem]

Branch: public/28603

[kliem]

New commits:

a005e47

added vertex_graph, deprecated edge_graph

[kliem]

Commit: a005e47

[LaisRast]

comment:4

It is good to go.

[LaisRast]

Reviewer: Laith Rastanawi

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

96346fa

improved deprecation warning

[sagetrac-git]

Changed commit from a005e47 to 96346fa

[jplab]

comment:7

Could the sentence also include what function the use should use instead?

[sagetrac-git]

Changed commit from 96346fa to 4b83abe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

4b83abe

deprecation warning gives new name

[kliem]

comment:9

Replying to @jplab:

Could the sentence also include what function the use should use instead?

Sure.

The deprecation warning doesn't show in normal use. When you run the doctest manually it won't show. If you pack it in

sage: def foo(C):
sage:     return C.edge_graph()

it is printed when calling foo.

[sagetrac-git]

Changed commit from 4b83abe to ecb7986

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ecb7986

changed stacklevel to 3, so deprecation warning shows during normal usage

[LaisRast]

comment:11

The deprecation warning is now printed out. So I will put it back on "positive review".

[vbraun]

Changed branch from public/28603 to ecb7986