CombinatorialPolyhedron: replace attributes by methods

[kliem]

Replace attributes in CombinatorialPolyhedron by methods, such that they can potentially be lazily evaluated.

More precisely we replace an attribute by a private attribute (with leading _) and add a method without leading _. E.g. the attribute far_face_tuple is replaced by _far_face_tuple and we add a method far_face_tuple(self). Thus we gain flexibility in the sense that those attributes must not be set on initialization.

This is motivated by #10777.

We remove the attribute Vinv completely, as it is not being used.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: d4b3163

Reviewer: Laith Rastanawi, Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28605

[kliem]

Branch: public/28605

[kliem]

New commits:

d597ed3	replace attributes by methods
2fc4fe0	removed empty folder being created in source
37592f9	replace attributes by methods; remove empty folder from source

[kliem]

Commit: 37592f9

[kliem]

Changed keywords from none to polytopes, combinatorial polyhedron

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e865f9d	removed attribute Vinv, as its not being used
84ef31b	added docstrings to the new methods
588afa4	removed method for Vinv

[sagetrac-git]

Changed commit from 37592f9 to 588afa4

[kliem]

comment:6

Adding #28625 as I'm using attributes in that ticket.

At moment I think #28625 might be finished before this here, but we can always revers dependencies and change it there.

[kliem]

Dependencies: #28625

[LaisRast]

Reviewer: Laith Rastanawi

[LaisRast]

comment:7

I went through the changes and they seem all legit.
So I will put this on "positive review".

[sagetrac-git]

Changed commit from 588afa4 to 9b5bcaa

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b89610e	added combinatorial polyhedron as an attribute for polyhedra
326602c	f_vector of CombinatorialPolyhedron is a vector
dfbe2ad	Merge branch 'public/28607' of git://trac.sagemath.org/sage into public/28621
ed5518b	used CombinatorialPolyhedron to compute f_vector
9bdd005	give an error message for polytopes in some cases; removed incorrect example
acd671d	now we get a precice error message for inexact truncated dodecahedron
bf85a62	subsequent calls for f_vector fail if first attempt fails
dc99ea4	Merge branch 'public/28625' of git://trac.sagemath.org/sage into public/28605
9b5bcaa	applied changes of 28605 to new code from 28625

[kliem]

comment:10

Failing doctest. Removing .cc to get rid of the empty folder doesn't seem to work.

Should probably just do this in an extra ticket and see what happens then.

[sagetrac-git]

Changed commit from 9b5bcaa to 473b15d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

473b15d

undid change to module list

[kliem]

comment:12

I think we should to the change to src/module_list.py in another ticket. There is no need to do it now, especially if it leads to problems.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

202cad9	replace attributes by methods
2e3e464	removed empty folder being created in source
7701062	removed attribute Vinv, as its not being used
1b17f6e	added docstrings to the new methods
c51cdd9	removed method for Vinv
dd21f9c	applied changes of 28605 to new code from 28625
4f49eac	undid change to module list

[sagetrac-git]

Changed commit from 473b15d to 4f49eac

[kliem]

Changed branch from public/28605 to public/28605-reb

[kliem]

Changed commit from 4f49eac to 0f3b121

[kliem]

New commits:

0f3b121

replace attributes by methods; remove attribute Vinv

[kliem]

Changed dependencies from #28625 to none

[sagetrac-git]

Changed commit from 0f3b121 to b0eac08

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b0eac08

replace attributes by methods; remove attribute Vinv

[jplab]

comment:18

Failing doctests on beta5.

[kliem]

Changed branch from public/28605-reb to public/28605-reb2

[kliem]

Changed commit from b0eac08 to d4b3163

[kliem]

New commits:

dd0729d	replace attributes by methods; remove attribute Vinv
d4b3163	small fix in ridges

[jplab]

Changed reviewer from Laith Rastanawi to Laith Rastanawi, Jean-Philippe Labbé

[jplab]

comment:20

Ok! Looks good to me now.

[vbraun]

Changed branch from public/28605-reb2 to d4b3163