Upgrade Arb to 2.18.1 #28623

fredrik-johansson · 2019-10-17T18:09:54Z

http://arblib.org/history.html#history

adds support for FLINT 2.6 (#29719)

tarball: See checksums.ini [upstream_url]

CC: @mezzarobba @videlec @kiwifb @antonio-rojas

Component: packages: standard

Author: Matthias Koeppe, Dima Pasechnik

Branch/Commit: 0c9c4ed

Reviewer: Dima Pasechnik, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/28623

The text was updated successfully, but these errors were encountered:

embray · 2020-01-06T14:10:03Z

comment:2

Ticket retargeted after milestone closed

mkoeppe · 2020-06-14T22:21:58Z

Branch: u/mkoeppe/upgrade_arb_to_2_18_0

mkoeppe · 2020-06-14T22:22:27Z

Author: Matthias Koeppe

mkoeppe · 2020-06-14T22:22:27Z

New commits:

`f9be33a`	`build/pkgs/arb: Update to 2.18.0`
`e7a25cb`	`build/pkgs/arb/patches/silence-stderr-exponent-too-large.patch: Remove`

mkoeppe · 2020-06-14T22:22:27Z

Commit: e7a25cb

timokau · 2020-06-15T19:58:13Z

comment:9

Have you run the testsuite? I just tried to do the update for sage in nixpkgs. We're still on sage 8.9, but I expect the failures would be the same with the current develop branch as the tests are still the same. Most of the test failures are due to precision improvements, but two (the nans) look like regressions:

sage -t --long /nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx", line 4510, in sage.rings.complex_arb.ComplexBall.elliptic_pi
Failed example:
    CBF(2,3).elliptic_pi(CBF(1,1))
Expected:
    [0.27029997361983 +/- ...e-15] + [0.715676058329095 +/- ...e-16]*I
Got:
    [0.2702999736198 +/- 4.51e-14] + [0.7156760583291 +/- 1.78e-14]*I
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx", line 4618, in sage.rings.complex_arb.ComplexBall.elliptic_pi_inc
Failed example:
    n.elliptic_pi_inc(CBF.pi()/2, m)
Expected:
    [0.8934793755173 +/- ...e-14] + [0.95707868710750 +/- ...e-15]*I
Got:
    nan + nan*I
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx", line 4620, in sage.rings.complex_arb.ComplexBall.elliptic_pi_inc
Failed example:
    n.elliptic_pi(m)
Expected:
    [0.89347937551733 +/- ...e-15] + [0.95707868710750 +/- ...e-15]*I
Got:
    [0.8934793755173 +/- 4.27e-14] + [0.9570786871075 +/- 9.91e-15]*I
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx", line 4625, in sage.rings.complex_arb.ComplexBall.elliptic_pi_inc
Failed example:
    n.elliptic_pi_inc(CBF.pi()/2, m)
Expected:
    [0.2969588746419 +/- ...e-14] + [1.3188795332738 +/- ...e-14]*I
Got:
    nan + nan*I
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx", line 4627, in sage.rings.complex_arb.ComplexBall.elliptic_pi_inc
Failed example:
    n.elliptic_pi(m)
Expected:
    [0.29695887464189 +/- ...e-15] + [1.31887953327376 +/- ...e-15]*I
Got:
    [0.2969588746419 +/- 3.79e-14] + [1.3188795332738 +/- 7.19e-14]*I
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/complex_arb.pyx", line 4703, in sage.rings.complex_arb.ComplexBall.elliptic_rj
Failed example:
    CBF(0,1).elliptic_rj(CBF(-1/2,1), CBF(-1,-1), CBF(2))
Expected:
    [1.004386756285733 +/- ...e-16] + [-0.2451626834391645 +/- ...e-17]*I
Got:
    [1.00438675628573 +/- 6.85e-15] + [-0.24516268343916 +/- 8.11e-15]*I
**********************************************************************
3 items had failures:
   1 of   2 in sage.rings.complex_arb.ComplexBall.elliptic_pi
   4 of  10 in sage.rings.complex_arb.ComplexBall.elliptic_pi_inc
   1 of   2 in sage.rings.complex_arb.ComplexBall.elliptic_rj
    [637 tests, 6 failures, 7.92 s]

File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/real_arb.pyx", line 295, in sage.rings.real_arb.arb_to_mpfi
Failed example:
    RIF(RBF(2)**(2**100)) # indirect doctest
Expected:
    Traceback (most recent call last):
    ...
    ArithmeticError: Error converting arb to mpfi. Overflow?
Got:
    [5.8756537891115869e1388255822130839282 .. +infinity]
**********************************************************************
File "/nix/store/6dnh3dcsfmj8akrifqy95wd57sfnprp6-sage-src-8.9/src/sage/rings/real_arb.pyx", line 1657, in sage.rings.real_arb.RealBall.mid
Failed example:
    b.mid()
Expected:
    Traceback (most recent call last):
    ...
    RuntimeError: unable to convert to MPFR (exponent out of range?)
Got:
    +infinity
**********************************************************************
2 items had failures:
   1 of   7 in sage.rings.real_arb.RealBall.mid
   1 of   2 in sage.rings.real_arb.arb_to_mpfi
    [539 tests, 2 failures, 0.71 s]

dimpase · 2020-06-16T07:38:31Z

comment:11

I don't see these arb errors if I update flint to 2.6 in lockstep with arb.

dimpase · 2020-06-16T07:38:31Z

Reviewer: Dima Pasechnik

timokau · 2020-06-16T14:00:32Z

comment:12

I get the same errors if I update flint as well, but if you're not seeing them that could also be caused by some other dependency / version difference of sage on nix.

dimpase · 2020-06-16T14:05:27Z

comment:13

our flint 2.6.0 update ticket has patches, did you use them?

mkoeppe · 2020-06-16T14:16:59Z

comment:14

Replying to @dimpase:

I don't see these arb errors if I update flint to 2.6 in lockstep with arb.

Perhaps then this ticket should depend on the FLINT ticket, not the other way around; or we should close this one and use #29719 for both updates.

timokau · 2020-06-16T14:17:57Z

comment:15

Replying to @dimpase:

our flint 2.6.0 update ticket has patches, did you use them?

No, but I don't see any relevant patches either. Only 0001-Makefile.in-macos-Do-not-make-DESTDIR-part-of-instal.patch was added, which is both MacOS and buildsystem specific.

dimpase · 2020-06-22T09:03:19Z

comment:16

some needed for doctests patches for arb are on #29719. Sorry for mess.

dimpase · 2020-06-22T09:03:19Z

Dependencies: #29719

dimpase · 2020-11-25T19:13:39Z

Changed commit from d6838a1 to 9515c6d

dimpase · 2020-11-25T19:13:39Z

Changed reviewer from Dima Pasechnik, ... to Dima Pasechnik

dimpase · 2020-11-25T19:13:39Z

comment:56

it all works just fine.

New commits:

`0a99383`	`build/pkgs/arb/patches/[flint.. silence-stderr-exponent-too-large].patch: Remove`
`e4005b1`	`update to 2.18.1`
`9515c6d`	`remove old workaround`

vbraun · 2020-12-04T23:57:23Z

comment:57

On 32-bit:

**********************************************************************
File "src/sage/rings/real_arb.pyx", line 300, in sage.rings.real_arb.arb_to_mpfi
Failed example:
    RIF(RBF(2)**(2**100)) # arb218 # indirect doctest
Expected:
    [5.8756537891115869e1388255822130839282 .. +infinity]
Got:
    [2.0985787164673874e323228496 .. +infinity]
**********************************************************************
1 item had failures:
   1 of   2 in sage.rings.real_arb.arb_to_mpfi
    [546 tests, 1 failure, 0.37 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/rings/real_arb.pyx  # 1 doctest failed
----------------------------------------------------------------------

dimpase · 2020-12-07T15:38:12Z

New commits:

`62fee73`	`build/pkgs/arb/patches/[flint.. silence-stderr-exponent-too-large].patch: Remove`
`bf63df7`	`update to 2.18.1`
`1120656`	`remove old workaround`
`0ce02a2`	`add 64/32-bit tags and results`

dimpase · 2020-12-07T15:38:12Z

Changed commit from 9515c6d to 0ce02a2

dimpase · 2020-12-07T15:38:12Z

Changed branch from u/mkoeppe/upgrade_arb_to_2_18_1 to u/dimpase/upgrade_arb_to_2_18_1

dimpase · 2020-12-07T15:38:51Z

comment:59

rebased over the latest beta and added tags. Please test on 32 bits in particular

sagetrac-git · 2020-12-07T21:14:23Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4e5e12d`	`add missing dots`

sagetrac-git · 2020-12-07T21:14:23Z

Changed commit from 0ce02a2 to 4e5e12d

dimpase · 2020-12-07T21:15:23Z

comment:61

passes all the tests on 32-bit now

sagetrac-git · 2020-12-07T23:08:50Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`0c9c4ed`	`correct the tags placement, add dots`

sagetrac-git · 2020-12-07T23:08:50Z

Changed commit from 4e5e12d to 0c9c4ed

dimpase · 2020-12-07T23:15:04Z

comment:63

duh, now it's finally right, passes both on 32 and 64 bits.

mkoeppe · 2020-12-08T01:29:27Z

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

mkoeppe · 2020-12-08T01:29:27Z

comment:64

LGTM

vbraun · 2020-12-13T20:31:13Z

Changed branch from u/dimpase/upgrade_arb_to_2_18_1 to 0c9c4ed

fredrik-johansson added this to the sage-9.0 milestone Oct 17, 2019

fredrik-johansson added c: packages: standard labels Oct 17, 2019

embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020

mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 24, 2020

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Upgrade Arb to 2.17.0~~ Upgrade Arb to 2.18.0 Jun 14, 2020

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Jun 14, 2020

mkoeppe added s: needs work and removed s: needs review labels Jun 15, 2020

dimpase added s: positive review and removed s: needs work labels Jun 16, 2020

dimpase added s: positive review and removed s: needs review labels Nov 25, 2020

vbraun added s: needs work and removed s: positive review labels Dec 4, 2020

dimpase added s: needs review and removed s: needs work labels Dec 7, 2020

mkoeppe added s: positive review and removed s: needs review labels Dec 8, 2020

vbraun removed the s: positive review label Dec 13, 2020

vbraun closed this as completed in 790c30d Dec 13, 2020

This was referenced Sep 27, 2020

Prepare doctests for Arb 2.18 #30486

Closed

fedora-33-standard/homebrew-macos flint/arb breakage #30757

Closed

Update arb to 2.19.0 #31516

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Arb to 2.18.1 #28623

Upgrade Arb to 2.18.1 #28623

fredrik-johansson commented Oct 17, 2019

embray commented Jan 6, 2020

This comment has been minimized.

mkoeppe commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

This comment has been minimized.

timokau commented Jun 15, 2020

dimpase commented Jun 16, 2020

dimpase commented Jun 16, 2020

timokau commented Jun 16, 2020

dimpase commented Jun 16, 2020

mkoeppe commented Jun 16, 2020

timokau commented Jun 16, 2020

dimpase commented Jun 22, 2020

dimpase commented Jun 22, 2020

dimpase commented Nov 25, 2020

dimpase commented Nov 25, 2020

dimpase commented Nov 25, 2020

vbraun commented Dec 4, 2020

dimpase commented Dec 7, 2020

dimpase commented Dec 7, 2020

dimpase commented Dec 7, 2020

dimpase commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

dimpase commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

dimpase commented Dec 7, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 8, 2020

vbraun commented Dec 13, 2020

Upgrade Arb to 2.18.1 #28623

Upgrade Arb to 2.18.1 #28623

Comments

fredrik-johansson commented Oct 17, 2019

embray commented Jan 6, 2020

This comment has been minimized.

mkoeppe commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

mkoeppe commented Jun 14, 2020

This comment has been minimized.

timokau commented Jun 15, 2020

dimpase commented Jun 16, 2020

dimpase commented Jun 16, 2020

timokau commented Jun 16, 2020

dimpase commented Jun 16, 2020

mkoeppe commented Jun 16, 2020

timokau commented Jun 16, 2020

dimpase commented Jun 22, 2020

dimpase commented Jun 22, 2020

dimpase commented Nov 25, 2020

dimpase commented Nov 25, 2020

dimpase commented Nov 25, 2020

vbraun commented Dec 4, 2020

dimpase commented Dec 7, 2020

dimpase commented Dec 7, 2020

dimpase commented Dec 7, 2020

dimpase commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

dimpase commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

sagetrac-git mannequin commented Dec 7, 2020

dimpase commented Dec 7, 2020

mkoeppe commented Dec 8, 2020

mkoeppe commented Dec 8, 2020

vbraun commented Dec 13, 2020