remove deprecated stuff in padics

[fchapoton]

after #14825

CC: @xcaruso @roed314 @saraedum @tscrim

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 3726356

Reviewer: Travis Scrimshaw, David Roe

Issue created by migration from https://trac.sagemath.org/ticket/28663

[fchapoton]

Branch: u/chapoton/28663

[fchapoton]

New commits:

bae385d

remove deprecated stuff in padics

[fchapoton]

Commit: bae385d

[fchapoton]

comment:2

green bot, please review (easy one)

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:3

LGTM.

[roed314]

comment:4

I'm fine with these changes, but if we're going to remove the expansion deprecations for padic_ZZ_pX_CA_element we should really do it for the others too.

padics$ git grep "14825"
local_generic_element.pyx:            See http://trac.sagemath.org/14825 for details.
padic_ZZ_pX_CA_element.pyx:            deprecation(14825, "Interface to expansion has changed; first argument now n")
padic_ZZ_pX_CA_element.pyx:    list = deprecated_function_alias(14825, expansion)
padic_ZZ_pX_CA_element.pyx:    teichmuller_list = deprecated_function_alias(14825, teichmuller_expansion)
padic_ZZ_pX_CR_element.pyx:            deprecation(14825, "Interface to expansion has changed; first argument now n")
padic_ZZ_pX_CR_element.pyx:    list = deprecated_function_alias(14825, expansion)
padic_ZZ_pX_CR_element.pyx:    teichmuller_list = deprecated_function_alias(14825, teichmuller_expansion)
padic_ZZ_pX_FM_element.pyx:            deprecation(14825, "Interface to expansion has changed; first argument now n")
padic_ZZ_pX_FM_element.pyx:    list = deprecated_function_alias(14825, expansion)
padic_ZZ_pX_FM_element.pyx:    teichmuller_list = deprecated_function_alias(14825, teichmuller_expansion)
padic_generic_element.pyx:            See http://trac.sagemath.org/14825 for details.
padic_generic_element.pyx:        deprecation(14825, "__getitem__ is changing to match the behavior of number fields. Please use expansion instead.")
padic_template_element.pxi:            See http://trac.sagemath.org/14825 for details.
padic_template_element.pxi:        deprecation(14825, "list is deprecated. Please use expansion instead.")
padic_template_element.pxi:            See http://trac.sagemath.org/14825 for details.
padic_template_element.pxi:        deprecation(14825, "teichmuller_list is deprecated. Please use teichmuller_expansion instead.")
padic_template_element.pxi:            See http://trac.sagemath.org/14825 for details.
padic_template_element.pxi:        deprecation(14825, "padded_list is deprecated.  Please use expansion or Integer.digits with the padto keyword instead.")

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3726356

remove more deprecated stuff from 14825

[sagetrac-git]

Changed commit from bae385d to 3726356

[fchapoton]

comment:6

ok. Done. I have left the ones concerning "getitem" aside, as they seem to warn about some future change, not yet in sage.

[roed314]

comment:8

Yeah, I think leaving __getitem__ alone until we make the change mentioned there seems fine. Looks good to me.

[roed314]

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, David Roe

[vbraun]

Changed branch from u/chapoton/28663 to 3726356