Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing optional flag in base_QQ.py #28700

Closed
jplab opened this issue Nov 6, 2019 · 11 comments
Closed

Fixing missing optional flag in base_QQ.py #28700

jplab opened this issue Nov 6, 2019 · 11 comments

Comments

@jplab
Copy link

jplab commented Nov 6, 2019

This is to fix the failing doctests in

https://groups.google.com/forum/#!topic/sage-release/tNBwvPmOXiI

present in the file base_QQ.py, following-up #18957

CC: @jplab @sophiasage @seblabbe

Component: geometry

Keywords: polytopes

Author: Sophia Elia

Branch/Commit: 07372b5

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28700

@jplab jplab added this to the sage-9.0 milestone Nov 6, 2019
@sophiasage
Copy link
Mannequin

sophiasage mannequin commented Nov 7, 2019

Branch: public/28700

@sophiasage
Copy link
Mannequin

sophiasage mannequin commented Nov 7, 2019

Commit: 19b0b1e

@sophiasage
Copy link
Mannequin

sophiasage mannequin commented Nov 7, 2019

New commits:

19b0b1eadding optionals in base_QQ

@jplab
Copy link
Author

jplab commented Nov 7, 2019

comment:2

Séb, could you check it on your computer? I can not reproduce the failure on my computer.

@jplab
Copy link
Author

jplab commented Nov 7, 2019

Author: Sophia Elia

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 8, 2019

Changed commit from 19b0b1e to 07372b5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 8, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

07372b5Chaning the marking so both packages are necessary.

@tscrim
Copy link
Collaborator

tscrim commented Nov 8, 2019

comment:5

I fixed it so both packages are required. This used to fail (pynormaliz installed but not latte_int) but now is passes for me.

@seblabbe
Copy link
Contributor

seblabbe commented Nov 8, 2019

Reviewer: Sébastien Labbé

@seblabbe
Copy link
Contributor

seblabbe commented Nov 8, 2019

comment:6

It fixes it.

@vbraun
Copy link
Member

vbraun commented Nov 14, 2019

Changed branch from public/28700 to 07372b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants