Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lawrence_extension and lawrence_polytope for backend field #28725

Closed
LaisRast opened this issue Nov 13, 2019 · 10 comments
Closed

fix lawrence_extension and lawrence_polytope for backend field #28725

LaisRast opened this issue Nov 13, 2019 · 10 comments

Comments

@LaisRast
Copy link

The methods lawrence extension and lawrence_polytope of Polyhedron do not work when the backend is field.

P = Polyhedron([[1,3], [3,4]], backend="field")
P.lawrence_extension([10,20])
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
TypeError: 'NoneType' object is not iterable

We fix this by properly initializing them with zero rays/lines instead of None.

CC: @jplab @kliem

Component: geometry

Keywords: polytopes, lawerence

Author: Laith Rastanawi, Jonathan Kliem

Branch/Commit: 50f9232

Reviewer: Laith Rastanawi, Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/28725

@LaisRast LaisRast added this to the sage-9.0 milestone Nov 13, 2019
@LaisRast

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Nov 13, 2019

New commits:

50f9232initialize Lawrence polytope with empty list of rays/lines instead of None

@kliem
Copy link
Contributor

kliem commented Nov 13, 2019

Reviewer: Laith Rastanawi, Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Nov 13, 2019

Branch: public/28725

@kliem

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Nov 13, 2019

Commit: 50f9232

@kliem
Copy link
Contributor

kliem commented Nov 13, 2019

Author: Laith Rastanawi, Jonathan Kliem

@LaisRast
Copy link
Author

comment:3

I think it is good to go.
I will wait for the patchbot to finish so I can put it on "positive review".

@kliem
Copy link
Contributor

kliem commented Nov 13, 2019

comment:4

Bot is morally green.

@vbraun
Copy link
Member

vbraun commented Nov 16, 2019

Changed branch from public/28725 to 50f9232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants