"The following package(s) may have failed to build": Improve output #28755

mkoeppe · 2019-11-18T15:52:36Z

This ticket improves the build error summary printed by build/make/install:

timestamps of the log files are shown, and packages are sorted chronologically by build time
build directory names are only printed if the directories still exist
some alignment for prettier output
rephrasing a message to make it clear that log files and build directories can be safely deleted.

Example output:

Error building Sage.

The following package(s) may have failed to build (not necessarily
during this run of 'make xyzzy'):

* package:         sage_numerical_backends_gurobi-9.0b9
  last build time: Dec 25 10:52
  log file:        /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/logs/pkgs/sage_numerical_backends_gurobi-9.0b9.log

* package:         sage_numerical_backends_cplex-9.0b9
  last build time: Dec 25 10:52
  log file:        /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/logs/pkgs/sage_numerical_backends_cplex-9.0b9.log

* package:         sage_numerical_backends_gurobi-9.0b12
  last build time: Jan 12 18:53
  log file:        /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/logs/pkgs/sage_numerical_backends_gurobi-9.0b12.log
  build directory: /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/local/var/tmp/sage/build/sage_numerical_backends_gurobi-9.0b12

* package:         gcc-9.2.0
  last build time: Jan 24 10:45
  log file:        /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/logs/pkgs/gcc-9.2.0.log
  build directory: /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/local/var/tmp/sage/build/gcc-9.2.0

It is safe to delete any log files and build directories, but they
contain information that is helpful for debugging build problems.
WARNING: If you now run 'make' again, the build directory of the
same version of the package will, by default, be deleted. Set the
environment variable SAGE_KEEP_BUILT_SPKGS=yes to prevent this.

make: *** [xyzzy] Error 1

CC: @embray @jdemeyer @dimpase @saraedum

Component: build

Author: Matthias Koeppe

Branch/Commit: 90a5e96

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/28755

The text was updated successfully, but these errors were encountered:

mkoeppe · 2019-11-24T14:58:55Z

Branch: u/mkoeppe/28755-show-timestamps-of-logfiles

mkoeppe · 2019-11-24T14:59:56Z

Author: Matthias Koeppe

mkoeppe · 2019-11-24T14:59:56Z

Commit: d6389c5

mkoeppe · 2019-11-24T14:59:56Z

New commits:

`d6389c5`	`Show timestamps of logfiles and build directories on error`

embray · 2020-01-06T14:10:03Z

comment:3

Ticket retargeted after milestone closed

mkoeppe · 2020-01-22T19:58:12Z

comment:4

Anyone interested in this?

jhpalmieri · 2020-01-23T05:42:31Z

comment:6

I don't see any good reason to print the contents of the build directory:

The following package(s) may have failed to build (not necessarily
during this run of 'make all-start'):

* package: cliquer-1.21.p4
-rw-r--r--  1 palmieri  staff  2383 Jan 22 20:48 /Users/palmieri/Desktop/Sage_stuff/sage_builds/TESTING/sage-9.1.beta1/logs/pkgs/cliquer-1.21.p4.log

/Users/palmieri/Desktop/Sage_stuff/sage_builds/TESTING/sage-9.1.beta1/local/var/tmp/sage/build/cliquer-1.21.p4:
total 72
drwxr-xr-x@ 12 palmieri  staff   384 Jan 22 20:48 .
drwxr-xr-x   4 palmieri  staff   128 Jan 22 20:51 ..
-rw-r--r--   1 palmieri  staff   519 Jan 22 20:43 spkg-configure.m4
-rwxr-xr-x   1 palmieri  staff  1430 Jan 22 20:48 spkg-check
-rw-r--r--@  1 palmieri  staff   164 Jan 21 13:56 dependencies
-rw-r--r--@  1 palmieri  staff     8 Jan 21 13:56 package-version.txt
-rw-r--r--@  1 palmieri  staff     9 Jan 21 13:56 type
-rwxr-xr-x@  1 palmieri  staff   406 Jan 21 13:56 spkg-src
-rw-r--r--@  1 palmieri  staff   130 Jan 21 13:56 checksums.ini
-rwxr-xr-x   1 palmieri  staff  1144 Jan 22 20:48 spkg-install
-rw-r--r--@  1 palmieri  staff   481 Jan 21 13:56 SPKG.txt
drwxr-xr-x  27 palmieri  staff   864 Jan 22 20:48 src

For most users, the log file has the relevant information.

For the timestamp itself, in principle it's a good idea, but using ls -l gives extraneous information, and unfortunately it's the first information printed: file permissions, owner, group, etc. The most important thing is the location of the file, second is the timestamp.

mkoeppe · 2020-01-23T15:30:49Z

comment:7

Thanks for the feedback! I'll prepare a prettier version.

sagetrac-git · 2020-01-24T15:48:29Z

Changed commit from d6389c5 to f48951b

sagetrac-git · 2020-01-24T15:48:29Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`6925827`	`Show timestamps of logfiles and build directories on error`
`f48951b`	`build/make/install: Show timestamps, suppress nonexisting build dirs, align output, rephrase messages`

jhpalmieri · 2020-01-24T18:33:01Z

comment:11

Now I see this, which I like better:

Error building Sage.

The following package(s) may have failed to build (not necessarily
during this run of 'make all-start'):

* package:         pari_galdata-20080411.p0
  last build time: Jan 24 10:25
  log file:        /Users/jpalmier/Desktop/Sage/sage_builds/28755/sage-9.1.beta1/logs/pkgs/pari_galdata-20080411.p0.log
  build directory: /Users/jpalmier/Desktop/Sage/sage_builds/28755/sage-9.1.beta1/local/var/tmp/sage/build/pari_galdata-20080411.p0

* package:         pari_seadata_small-20090618.p0
  last build time: Jan 24 10:25
  log file:        /Users/jpalmier/Desktop/Sage/sage_builds/28755/sage-9.1.beta1/logs/pkgs/pari_seadata_small-20090618.p0.log
  build directory: /Users/jpalmier/Desktop/Sage/sage_builds/28755/sage-9.1.beta1/local/var/tmp/sage/build/pari_seadata_small-20090618.p0
ls: /Users/jpalmier/Desktop/Sage/sage_builds/28755/sage-9.1.beta1/logs/pkgs/../doc*.log: No such file or directory

It is safe to delete any log files and build directories, but they
contain information that is helpful for debugging build problems.
WARNING: If you now run 'make' again, the build directory of the
same version of the package will, by default, be deleted. Set the
environment variable SAGE_KEEP_BUILT_SPKGS=yes to prevent this.

make[1]: *** [all-start] Error 1
make: *** [all] Error 2

However I do not like the error message

ls: /Users/jpalmier/Desktop/Sage/sage_builds/28755/sage-9.1.beta1/logs/pkgs/../doc*.log: No such file or directory

sagetrac-git · 2020-01-24T20:50:42Z

Branch pushed to git repo; I updated commit sha1. New commits:

`90a5e96`	`Suppress error messages when there is no log file`

sagetrac-git · 2020-01-24T20:50:42Z

Changed commit from f48951b to 90a5e96

jhpalmieri · 2020-01-24T21:34:21Z

Reviewer: John Palmieri

jhpalmieri · 2020-01-24T21:34:21Z

comment:13

That's better.

mkoeppe · 2020-01-24T21:42:48Z

comment:14

Thanks for reviewing!

vbraun · 2020-01-25T17:27:02Z

Changed branch from u/mkoeppe/28755-show-timestamps-of-logfiles to 90a5e96

mkoeppe added this to the sage-9.0 milestone Nov 18, 2019

mkoeppe added c: build labels Nov 18, 2019

mkoeppe added the s: needs review label Nov 24, 2019

embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020

mkoeppe added s: needs work and removed s: needs review labels Jan 23, 2020

This comment has been minimized.

Sign in to view

mkoeppe added s: needs review and removed s: needs work labels Jan 24, 2020

mkoeppe changed the title ~~"The following package(s) may have failed to build": Show timestamps of logfiles~~ "The following package(s) may have failed to build": Improve output Jan 24, 2020

jhpalmieri added s: positive review and removed s: needs review labels Jan 24, 2020

jhpalmieri added p: minor / 4 and removed p: major / 3 labels Jan 24, 2020

vbraun removed the s: positive review label Jan 25, 2020

vbraun closed this as completed in 7cec05e Jan 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"The following package(s) may have failed to build": Improve output #28755

"The following package(s) may have failed to build": Improve output #28755

mkoeppe commented Nov 18, 2019

mkoeppe commented Nov 24, 2019

mkoeppe commented Nov 24, 2019

mkoeppe commented Nov 24, 2019

mkoeppe commented Nov 24, 2019

embray commented Jan 6, 2020

mkoeppe commented Jan 22, 2020

jhpalmieri commented Jan 23, 2020

mkoeppe commented Jan 23, 2020

sagetrac-git mannequin commented Jan 24, 2020

sagetrac-git mannequin commented Jan 24, 2020

This comment has been minimized.

jhpalmieri commented Jan 24, 2020

sagetrac-git mannequin commented Jan 24, 2020

sagetrac-git mannequin commented Jan 24, 2020

jhpalmieri commented Jan 24, 2020

jhpalmieri commented Jan 24, 2020

mkoeppe commented Jan 24, 2020

vbraun commented Jan 25, 2020

"The following package(s) may have failed to build": Improve output #28755

"The following package(s) may have failed to build": Improve output #28755

Comments

mkoeppe commented Nov 18, 2019

mkoeppe commented Nov 24, 2019

mkoeppe commented Nov 24, 2019

mkoeppe commented Nov 24, 2019

mkoeppe commented Nov 24, 2019

embray commented Jan 6, 2020

mkoeppe commented Jan 22, 2020

jhpalmieri commented Jan 23, 2020

mkoeppe commented Jan 23, 2020

sagetrac-git mannequin commented Jan 24, 2020

sagetrac-git mannequin commented Jan 24, 2020

This comment has been minimized.

jhpalmieri commented Jan 24, 2020

sagetrac-git mannequin commented Jan 24, 2020

sagetrac-git mannequin commented Jan 24, 2020

jhpalmieri commented Jan 24, 2020

jhpalmieri commented Jan 24, 2020

mkoeppe commented Jan 24, 2020

vbraun commented Jan 25, 2020