Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kneading sequences for the doubling map #28772

Closed
sagetrac-jdoyle mannequin opened this issue Nov 19, 2019 · 21 comments
Closed

Kneading sequences for the doubling map #28772

sagetrac-jdoyle mannequin opened this issue Nov 19, 2019 · 21 comments
Labels
c: dynamics p: minor / 4 t: enhancement
Milestone
sage-9.1

Comments

@sagetrac-jdoyle
Copy link
Mannequin

sagetrac-jdoyle mannequin commented Nov 19, 2019

Given an angle theta in RR/ZZ, the kneading sequence of theta is a binary string that gives information about the dynamics of theta under the doubling map. These combinatorial kneading sequences are useful for understanding dynamics near the roots of hyperbolic components of the Mandelbrot set.

Depends on #28557

Component: dynamics

Keywords: sd104, mandelbrot

Author: John Doyle

Branch/Commit: 3a03181

Reviewer: John Michael Clark

Issue created by migration from https://trac.sagemath.org/ticket/28772
@sagetrac-jdoyle sagetrac-jdoyle mannequin added this to the sage-9.0 milestone Nov 19, 2019
@sagetrac-jdoyle
Copy link
Mannequin Author

sagetrac-jdoyle mannequin commented Nov 19, 2019

Branch: u/jdoyle/kneading_sequences

@sagetrac-jdoyle
Copy link
Mannequin Author

sagetrac-jdoyle mannequin commented Nov 19, 2019

Commit: 99ed665

@sagetrac-jdoyle
Copy link
Mannequin Author

sagetrac-jdoyle mannequin commented Nov 19, 2019

Changed branch from u/jdoyle/kneading_sequences to u/jdoyle/kneading_sequence_new

@sagetrac-jdoyle
Copy link
Mannequin Author

sagetrac-jdoyle mannequin commented Nov 19, 2019

New commits:

99ed665Cleaned up the branch

@JohnClarkSage
Copy link
Mannequin

JohnClarkSage mannequin commented Nov 20, 2019

Reviewer: John Michael Clark

@JohnClarkSage
Copy link
Mannequin

JohnClarkSage mannequin commented Nov 20, 2019

comment:4

All tests passed.

@vbraun
Copy link
Member

vbraun commented Nov 30, 2019

comment:5

Merge conflict

@DaveWitteMorris
Copy link
Member

comment:6

LGTM. I resolved the merge conflict and made a few minor edits. This is not my ticket, but it has been sitting for a month and I am working on other functions in the same file (see #28923), so I would like to see this closed.

@DaveWitteMorris
Copy link
Member

Changed branch from u/jdoyle/kneading_sequence_new to public/28772

@DaveWitteMorris
Copy link
Member

Changed commit from 99ed665 to 3197d5d

@DaveWitteMorris
Copy link
Member

New commits:

bcdb32dmerged ticket 28772 into 9.0
3197d5dminor edits

@JohnClarkSage
Copy link
Mannequin

JohnClarkSage mannequin commented Jan 2, 2020

comment:9

All tests passed.

@fchapoton fchapoton modified the milestones: sage-9.0, sage-9.1 Jan 2, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9f9d6aefixed pyflakes error

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2020

Changed commit from 3197d5d to 9f9d6ae

@sagetrac-git sagetrac-git mannequin removed the s: positive review label Jan 3, 2020
@sagetrac-git sagetrac-git mannequin added the s: needs review label Jan 3, 2020
@DaveWitteMorris
Copy link
Member

comment:12

Fixed an error that was reported by pyflakes. (DynamicalSystem was imported twice.) Please review again.

@DaveWitteMorris
Copy link
Member

comment:13

There is a (minor) merge conflict with #28557. I resolved the conflict and will upload the PR after I have tested it.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2020

Changed commit from 9f9d6ae to 3a03181

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

9310d7928557: fixed the radius in julia_plot
9adac1728557: fix R_c in documentation and remove whitespace
b098431Merge tag '9.0.beta9' into 28557
a5a0408fix pyflakes failures
4da66a2merge ticket 28557 into 9.0
3a03181merged ticket 28772 into 28557

@JohnClarkSage
Copy link
Mannequin

JohnClarkSage mannequin commented Jan 3, 2020

comment:16

Looks good on my end. All tests passed.

@DaveWitteMorris
Copy link
Member

Dependencies: #28557

@vbraun
Copy link
Member

vbraun commented Jan 11, 2020

Changed branch from public/28772 to 3a03181

@vbraun vbraun closed this as completed in 6c520b2 Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: dynamics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @DaveWitteMorris