Remove sagenb from DOC_DEPENDENCIES

[kiwifb]

We took care of removing all the dependencies to sagenb during build, in particular, the build of documentation. We also have switched to python3 by default but sagenb is still installed in python3 builds because of its presence in DOC_DEPENDENCIES. It should be removed.

CC: @jhpalmieri @embray @isuruf @timokau

Component: documentation

Author: François Bissey, John Palmieri

Branch/Commit: e234ff5

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28805

[kiwifb]

Author: François Bissey

[kiwifb]

Branch: u/fbissey/doc_sagenb_less

[kiwifb]

Commit: a028f89

[kiwifb]

comment:1

And with this commit sagenb is well and truly optional. Its installation will require manual intervention.

---

New commits:

a028f89

remove sagenb from DOC_DEPENDENCIES

[jhpalmieri]

comment:2

I'm seeing doctest failures in tests/cmdline.py because the script sage-rst2txt tries to import sagenb. I guess that test should be tagged # py2. Actually, should many of the py2 tags in that file be changed to optional: sagenb?

Maybe it's better to keep them as py2 so that we can find them and delete them more easily, once we drop support for Python 2.

[jhpalmieri]

Changed branch from u/fbissey/doc_sagenb_less to u/jhpalmieri/doc_sagenb_less

[kiwifb]

Changed commit from a028f89 to e234ff5

[kiwifb]

comment:4

Actually I removed all those from sage-on-gentoo. I was wondering why I was the only one seemingly seeing these failures.

---

New commits:

e234ff5

trac 28805: tag some tests "# py2"

[fchapoton]

comment:5

looks good to me. Any other opinion ?

[jhpalmieri]

comment:6

It works for me. I'm happy with the basic setup, so someone should review my commit.

[dimpase]

comment:7

does rst2txt need Pyhton2, or sagenb? and if yes, why?

[jhpalmieri]

comment:8

The script sage-rst2txt contains the line

from sagenb.notebook.docHTMLProcessor import docutilsHTMLProcessor

and that import is in fact used.

As I said in comment:2, we could tag the relevant tests as # optional - sagenb, but I think we will eventually want to delete tests marked # py2, and then we might forget to deal with tests marked with sagenb instead.

[dimpase]

comment:9

docutilsHTMLProcessor can be trivially pulled out of sagenb. I don't know whether it's of any use though, but still...

[jhpalmieri]

comment:11

Replying to @dimpase:

docutilsHTMLProcessor can be trivially pulled out of sagenb. I don't know whether it's of any use though, but still...

The purpose of sage-rst2txt is "Translate a rst file into a worksheet txt file." I'm not sure what a "worksheet txt file" is, but I think it's for SageNB. So I don't see the point of separating sage-rst2txt from sagenb.

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:12

OK, fine, I should have read the output of sage --rst2txt, sorry. Thanks.

[kiwifb]

Changed author from François Bissey to François Bissey, John Palmieri

[vbraun]

Changed branch from u/jhpalmieri/doc_sagenb_less to e234ff5