Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database_stein_watkins Python 3 issues #28816

Closed
vbraun opened this issue Nov 28, 2019 · 9 comments
Closed

database_stein_watkins Python 3 issues #28816

vbraun opened this issue Nov 28, 2019 · 9 comments

Comments

@vbraun
Copy link
Member

vbraun commented Nov 28, 2019

There seem to be various places with bytes / string confusion when building on Python 3, e.g.:

**********************************************************************
File "src/sage/databases/stein_watkins.py", line 50, in sage.databases.stein_watkins
Failed example:
    next(d)                                       # optional - database_stein_watkins
Exception raised:
    Traceback (most recent call last):
      File "/var/lib/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 681, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/var/lib/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1123, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.databases.stein_watkins[4]>", line 1, in <module>
        next(d)                                       # optional - database_stein_watkins
      File "/var/lib/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage/databases/stein_watkins.py", line 242, in __next__
        return next(self._iter)
      File "/var/lib/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage/databases/stein_watkins.py", line 228, in __iter__
        N = int(x[0])
    ValueError: invalid literal for int() with base 10: b'[0,-1,1,0,0]'
**********************************************************************

CC: @williamstein @sagetrac-kimball

Component: packages: optional

Keywords: databases, stein-watkins

Author: Alex J. Best

Branch/Commit: ef49c0a

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/28816

@vbraun vbraun added this to the sage-8.9 milestone Nov 28, 2019
@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:1

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 May 7, 2020
@alexjbest
Copy link
Contributor

Branch: u/alexjbest/stein-watkins

@alexjbest
Copy link
Contributor

comment:4

I tried to fix this, as I understand it 9.2 will be python2 incompatible so I didn't worry about backwards compatibility.


New commits:

ef49c0afix file encoding for Stein-Watkins database in python3

@alexjbest
Copy link
Contributor

Commit: ef49c0a

@alexjbest
Copy link
Contributor

Author: Alex J. Best

@alexjbest
Copy link
Contributor

Changed keywords from none to databases, stein-watkins

@mwageringel
Copy link

Reviewer: Markus Wageringel

@mwageringel
Copy link

comment:6

Ok, this works for me.

@vbraun
Copy link
Member Author

vbraun commented Aug 15, 2020

Changed branch from u/alexjbest/stein-watkins to ef49c0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants